Add python hachoir-metadata #31044
Add python hachoir-metadata #31044
Conversation
|
I think these should be a single formula that installs all the parts. |
|
Ok I think then only hachoir-metadata is needed |
spk
changed the title
|
I updated this PR to have one commit and install only hachoir-metadata |
|
@BrewTestBot test this please |
|
|
||
| depends_on :python if MacOS.version <= :snow_leopard | ||
|
|
||
| resource 'hachoir-core' do |
There was a problem hiding this comment.
Use double-quotes everywhere.
|
Looking much better! A few suggestions. |
|
Hope you will like it ! |
| end | ||
|
|
||
| test do | ||
| output = `#{bin}/hachoir-metadata --version` |
There was a problem hiding this comment.
This is still just checking the version. Could you do something to actually run the tool on some input?
|
I'm creating a one sized pixel png file and test the mime type is equal to |
|
Seems that |
|
It's working fine locally I'm under 10.9.4 OS X, can I have some help ? |
|
It's failing under 10.7 and 10.8. Perhaps you should add a failure message to the assertions so we can see which one is failing. |
|
@MikeMcQuaid It's the mime test that failing but no output... Do you have an idea ? I'm new to OS X environment. |
| require "formula" | ||
|
|
||
| class HachoirMetadata < Formula | ||
| VERSION = '1.3.3' |
There was a problem hiding this comment.
Remove this; just use version in the formula where you need to access it instead.
|
@spk I'm not sure what's going on there. We could perhaps limit it to Mavericks and add a comment if someone else wants to fix it in future? @mistydemeo @adamv @jacknagel Any thoughts? |
no outputs for mime type on 10.7 and 10.8
|
If people don't want to debug my stuff I can understand. I limit then to Mavericks. Thanks for the helps ! |
|
In fact, I've got an idea of what it might be. Those versions are running Ruby 1.8 so the unicode output may be different. I think it might be better to just create a PNG and put it in the Homebrew repo. @jacknagel @mistydemeo @adamv any objections to me putting a single, small image in the repo to use as test data? It would also help with formulae like |
|
Ah ok cool, where can I put it ? |
|
@spk Hold off for a bit while I wait for the other maintainers to weigh in. |
|
A small png in the test folder seems fine. |
|
@MikeMcQuaid Sorry ! I'm waiting for GO ! |
|
@spk Can you put a 1x1 PNG file in |
|
Roger o> |
|
\o/ |
|
Thanks for all your work here! |
Added formula to install hachoir.