Updated the Subversion formula to upstream version 1.8.11. #35970
Conversation
and Serf version 1.3.8. Also removed part of the patch for configure that is no longer needed, and tweaked the remaining hunk of that patch so that it applies without fuzz.
According to the build test logs, the Mountain Lion bot failed on clang-format, not subversion. Can anyone shed any light on that? At least I can't see anything from the bot logs that could be related to the patch for the Subversion formula. |
Looks like it actually failed to find
Probably unrelated, if a little strange. |
sha1 "18a00000ae92b6b6bad79f3b84f0ffcba4e655f7" => :mountain_lion | ||
# sha1 "fea8a67fd177ba418c9185423d4ce8055d8f2ef5" => :yosemite | ||
# sha1 "ab3d546951f17ce2f2159a4e6bbf0c10b0c6a4c0" => :mavericks | ||
# sha1 "18a00000ae92b6b6bad79f3b84f0ffcba4e655f7" => :mountain_lion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should leave this as it is. Comment this out would make the bot think it's the real comment.
@DomT4, that may indicate a bug in homebrew core. Since |
That's a solid point. I guess in this context, |
Remove the estraneios "revision 0" line from the formula.
The second commit tweaks the formula as suggested by xu-cheng, and updates the bottle hashes to match what's currently available for download from SourceForge. |
sha1 "18a00000ae92b6b6bad79f3b84f0ffcba4e655f7" => :mountain_lion | ||
sha1 "a8f34972b8817b6d8b265dca8989ca2250e50c95" => :yosemite | ||
sha1 "813231b435ed014e40272f71935b775403e92d80" => :mavericks | ||
sha1 "e01c9dac41de8f0948ff2d2034951b86ed00d267" => :mountain_lion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave these as-is; we'll update them when we pull.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed that bit in the formula cookbook. Reverted.
Yeh, done in 3ecff95 |
Thanks for your contribution to Homebrew! For future reference the preferred commit message format for simple version updates is |
Updated the Subversion formula to upstream version 1.8.11 and Serf version 1.3.8. Also removed part of the patch for configure that is no longer needed, and tweaked the remaining hunk of that patch so that it applies without fuzz.