Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Updated the Subversion formula to upstream version 1.8.11. #35970

Closed
wants to merge 3 commits into from
Closed

Updated the Subversion formula to upstream version 1.8.11. #35970

wants to merge 3 commits into from

Conversation

brainy
Copy link
Contributor

@brainy brainy commented Jan 17, 2015

Updated the Subversion formula to upstream version 1.8.11 and Serf version 1.3.8. Also removed part of the patch for configure that is no longer needed, and tweaked the remaining hunk of that patch so that it applies without fuzz.

and Serf version 1.3.8. Also removed part of the patch for
configure that is no longer needed, and tweaked the remaining
hunk of that patch so that it applies without fuzz.
@brainy
Copy link
Contributor Author

brainy commented Jan 17, 2015

According to the build test logs, the Mountain Lion bot failed on clang-format, not subversion. Can anyone shed any light on that? At least I can't see anything from the bot logs that could be related to the patch for the Subversion formula.

@DomT4
Copy link
Member

DomT4 commented Jan 17, 2015

Looks like it actually failed to find gcc, rather than anything here.

Testing clang-format
==> /usr/local/Cellar/clang-format/2014-12-03/bin/clang-format -style=Google test.c
dyld: Library not loaded: /usr/local/lib/gcc/4.9/libatomic.1.dylib
  Referenced from: /usr/local/Cellar/clang-format/2014-12-03/bin/clang-format
  Reason: image not found
Error: clang-format: failed
<0> expected but was
<nil>.

Probably unrelated, if a little strange.

sha1 "18a00000ae92b6b6bad79f3b84f0ffcba4e655f7" => :mountain_lion
# sha1 "fea8a67fd177ba418c9185423d4ce8055d8f2ef5" => :yosemite
# sha1 "ab3d546951f17ce2f2159a4e6bbf0c10b0c6a4c0" => :mavericks
# sha1 "18a00000ae92b6b6bad79f3b84f0ffcba4e655f7" => :mountain_lion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should leave this as it is. Comment this out would make the bot think it's the real comment.

@xu-cheng
Copy link
Member

@DomT4, that may indicate a bug in homebrew core. Since clang-format fails with clang on Mountain Lion, it's built with gcc. However, in the test, clang-format is installed through bottle and fails to install gcc as a dependence. cc @MikeMcQuaid for this.

@DomT4
Copy link
Member

DomT4 commented Jan 17, 2015

That's a solid point. I guess in this context, gcc is technically treated as a build-time dep, when it may be a run-time dep. Perhaps the formula needs adjusting consequently - Although that it is only failing on the one bot machine is a little curious.

Remove the estraneios "revision 0" line from the formula.
@brainy
Copy link
Contributor Author

brainy commented Jan 17, 2015

The second commit tweaks the formula as suggested by xu-cheng, and updates the bottle hashes to match what's currently available for download from SourceForge.

sha1 "18a00000ae92b6b6bad79f3b84f0ffcba4e655f7" => :mountain_lion
sha1 "a8f34972b8817b6d8b265dca8989ca2250e50c95" => :yosemite
sha1 "813231b435ed014e40272f71935b775403e92d80" => :mavericks
sha1 "e01c9dac41de8f0948ff2d2034951b86ed00d267" => :mountain_lion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave these as-is; we'll update them when we pull.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed that bit in the formula cookbook. Reverted.

@MikeMcQuaid
Copy link
Member

That's a solid point. I guess in this context, gcc is technically treated as a build-time dep, when it may be a run-time dep. Perhaps the formula needs adjusting consequently - Although that it is only failing on the one bot machine is a little curious.

Yeh, done in 3ecff95

@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! For future reference the preferred commit message format for simple version updates is subversion 1.8.11.

@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants