Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

stem-1.3.0 added #38911

Closed
wants to merge 1 commit into from
Closed

stem-1.3.0 added #38911

wants to merge 1 commit into from

Conversation

sambuddhabasu
Copy link

The stem-1.3.0 has been added to the homebrew formula.
Details about the package can be seen at https://stem.torproject.org/

@sambuddhabasu sambuddhabasu force-pushed the addstem1.3.0 branch 3 times, most recently from 5878d36 to 06eed52 Compare April 21, 2015 23:44
MikeMcQuaid
MikeMcQuaid reviewed Apr 22, 2015
View reviewed changes
Library/Formula/stem.rb
system "python", *Language::Python.setup_install_args(prefix)
end

test do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a test be added to do something more substantial than e.g. --version or --help? See cmake.rb for an example of an application formula with a good test and tinyxml2.rb for an example of a library formula with a good test. Thanks!

@sambuddhabasu
stem-1.3.0 added
789e690 
Added test do

Removed testing modules for stem

Remove mock and modify pycrypto to be optional

Fixed brew audit --strict stem

Added test
@sambuddhabasu
Copy link
Author

@MikeMcQuaid I have made the required changes. Please have a look at it and let me know if it is ready to be merged.

@MikeMcQuaid
Copy link
Member

Oh, is this just a library? We don't really include Python libraries in Homebrew as pip does a better job.

@sambuddhabasu
Copy link
Author

Yes, this is a python module.
This was needed so that people who don't have pip can make use of Homebrew and install the module.
The ticket for this can be seen here https://trac.torproject.org/projects/tor/ticket/8588
Please take this into consideration. Thanks

@MikeMcQuaid
Copy link
Member

Everyone on OSX has easy_install available so they can use that or install pip. Sorry, will pass on this as we don't package Python libraries.

@sambuddhabasu sambuddhabasu mentioned this pull request Apr 23, 2015
Closed
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
new formula
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sambuddhabasu @MikeMcQuaid @asparagui