rtl-sdr 0.5.3: migrate from head-only (releases now provided on GitHub) #39574
Conversation
|
Aware of and working on the buildbot errors. |
L2G
force-pushed
the
formula/rtl-sdr
branch
4 times, most recently
from
ebd0a93
to
86175e7
Compare
|
This is affected by #39620. |
|
Also, there may be some CMake complications here. It all seems to build fine on my Mavericks system, and libusb certainly looks like it's 1.0.x. Does Jenkins save the build logs in its artifacts or elsewhere? |
|
This probably needs a |
| test do | ||
| assert_match( | ||
| %r{^rtl_sdr, an I/Q recorder for RTL2832 based DVB-T receivers$}m, | ||
| shell_output("#{bin}/rtl_sdr 2>&1", 1), |
There was a problem hiding this comment.
I just disabled the rubocop rule that asked for this trailing comma, because it's a syntax error on Ruby 1.8.
|
Should be past the rubocop weirdness now. |
Since libusb is already 1.0, I'm not sure what to do about this. Note that I have only seen this happen in the Jenkins builds. On my Mavericks system, there is no error. |
|
Which build is that occurring in? The latest push turned blue/green on Yosemite and Mavericks bots, Mountain Lion still threw the syntax failure on the test block. |
|
I just added I have a hunch there is something going on with superenv not fully sanitizing the environment of references to pkg-config. I say that because in my personal build that succeeded without the explicit pkg-config dependency, CMake found pkg-config at /usr/local/bin/pkg-config -- but /usr/local was not the Homebrew prefix I was trying to use at the time (I had no references to /usr/local/bin in my |
| end | ||
|
|
||
| test do | ||
| assert_match %r{^rtl_sdr, an I/Q recorder for RTL2832 based DVB-T receivers$}m, shell_output("#{bin}/rtl_sdr 2>&1", 1) |
There was a problem hiding this comment.
Do a shorter match, don't need to match full lines like this. Also would be good to reduce the length of this line so it can wrap at 80 chars.
|
Couple of comments here that need addressing from Mike, but otherwise looks great. |
Releases are tagged on the GitHub repo, which is considered the "official mirror."
|
Closing the PR since this has been added as |
From the rtl-sdr home page:
In light of the mirror's "official" status and its holding of versioned releases, I thought maybe this formula could graduate to core.