This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Add OpenMP support to ImageMagick. #40129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,6 +49,8 @@ class Imagemagick < Formula | |||
| depends_on "fftw" => :optional | |||
| depends_on "pango" => :optional | |||
|
|
|||
| needs :openmp | |||
There was a problem hiding this comment.
Sorry missed this. But in your case, it should be needs :openmp if build.with? "openmp"
There was a problem hiding this comment.
Should I make --with- or --without-openmp the default?
There was a problem hiding this comment.
Since, clang doesn't support openmp yet. Let's disable openmp as default.
It will require an OpenMP-enabled compiler then..
|
OK, check again. |
|
Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! For future reference the preferred commit message format is |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenMP support increases ImageMagick's performance greatly. This patch enables OpenMP when the compiler is GCC. When the compiler is Clang, or when
--without-openmpis specified on the command line, OpenMP is disabled.