added ppl-1.1 #40986
added ppl-1.1 #40986
Conversation
| class Ppl < Formula | ||
| desc "Parma Polyhedra Library" | ||
| homepage "http://bugseng.com/products/ppl" | ||
| url "ftp://ftp.cs.unipr.it/pub/ppl/releases/1.1/ppl-1.1.tar.xz" |
There was a problem hiding this comment.
http is preferred over ftp; I'd suggest to use this url:
http://bugseng.com/products/ppl/download/ftp/releases/1.1/ppl-1.1.tar.xz
|
OK, I took all comments into account |
| "--prefix=#{prefix}" | ||
| system "make", "install" | ||
| end | ||
| end |
There was a problem hiding this comment.
Can a test be added to do something more substantial than e.g. --version or --help? See cmake.rb for an example of an application formula with a good test and tinyxml2.rb for an example of a library formula with a good test. Thanks!
There was a problem hiding this comment.
I don't know how to do this: you would have to go where the software was compiled and run 'make check'.
There was a problem hiding this comment.
Please look at the referenced formulae.
|
I added the license info in the desc field |
|
I just added a test target inspired by the one from tinyxml2.rb |
|
Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock! For future reference the preferred commit message format for new formulae is |
Closes Homebrew#40986. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
No description provided.