rtmidi 2.1.0 (new formula)

[robhardwick]

RtMidi - a set of C++ classes that provide a common API for realtime
MIDI input/output across Linux (ALSA & JACK), Macintosh OS X (CoreMidi &
JACK) and Windows (Multimedia).

[DomT4]

==> brew style rtmidi

1 file inspected, no offenses detected
Error: 3 problems in 1 formula

==> audit problems
rtmidi:
 * A `test do` test block should be added
 * autoconf dependency should be
  depends_on "autoconf" => :build
Or if it is indeed a runtime denpendency
  depends_on "autoconf" => :run
 * Use `system "make", "librtmidi.a"` instead of `system "make librtmidi.a"` 

[MikeMcQuaid]

Is there no make install we can use?

[robhardwick]

Unfortunately, using make install with the generated Makeflle doesn't seem to work:

$ make install
install --mode=755 librtmidi.a /private/tmp/rtmidi20150629-3073-18yemi8/rtmidi-2.1.0/test/lib/
install: illegal option -- -
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...
make: *** [install] Error 64

It looks like the issue is caused by the long form of the --mode option which isn't supported by install on OS X. Any ideas?

[mistydemeo]

Do you mind reporting that to the developers? They may not be aware this is incompatible.

[mistydemeo]

Actually, it looks like the buildsystem has changed a lot since the 2.1.0 release - this doesn't seem to be an issue with upcoming versions, so we can just work around it and/or backport the makefile patches.

[robhardwick]

Would it be OK to merge this as-is and then update to a cleaner install method when the next verison of RtMidi is released? If not, is there anything I could do?

[mistydemeo]

I'm fine with merging now and cleaning up in the next release. Thank you!