pgroonga 0.6.0 (new formula) #41174
pgroonga 0.6.0 (new formula) #41174
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
class Pgroonga < Formula | ||
desc "An extension for PostgreSQL to use Groonga as an index." | ||
homepage "https://pgroonga.github.io/" | ||
url "http://packages.groonga.org/source/pgroonga/pgroonga-0.6.0.tar.gz" | ||
sha256 "29a631f68013bba19321beac0d7b933eafce60aec1597aa8fff0b0898ff2a73d" | ||
|
||
depends_on "pkg-config" => :build | ||
depends_on "postgresql" | ||
depends_on "groonga" | ||
|
||
def pour_bottle? | ||
# Postgres extensions must live in the Postgres prefix, which precludes | ||
# bottling: https://github.com/Homebrew/homebrew/issues/10247 | ||
# Overcoming this will likely require changes in Postgres itself. | ||
false | ||
end | ||
|
||
def install | ||
system "make" | ||
system "make", "install" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needs a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
end | ||
|
||
test do | ||
postgres_realpath = Formula["postgresql"].opt_prefix.realpath | ||
File.exist?("#{postgres_realpath}/share/postgresql/extension/pgroonga--#{version}.sql") | ||
end | ||
end | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can a test be added to do something more substantial than e.g. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm..., it's a bit difficult to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, Pgroonga should be put as a optional resource of Postgres rather than a standalone formula.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍. We should also do that with
postgis
too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 For me.