Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

New formula: muttvcardsearch 1.9 #41205

Closed
wants to merge 1 commit into from
Closed

New formula: muttvcardsearch 1.9 #41205

wants to merge 1 commit into from

Conversation

benjaminfrank
Copy link
Contributor

A small mutt carddav search utility for your Owncloud or SOGo server.

DomT4
DomT4 reviewed Jun 30, 2015
View reviewed changes
Library/Formula/muttvcardsearch.rb
sha256 "4c099938dd02f577d8289bbc5e82f0af6f290a564a30f6fdcb5cc880cd02fc8d"

option "with-debug", "build debug version"
depends_on "cmake" => :build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing between options and deps please.

@DomT4
Copy link
Member

DomT4 commented Jul 2, 2015

@BrewTestBot test this please

MikeMcQuaid
MikeMcQuaid reviewed Jul 2, 2015
View reviewed changes
Library/Formula/muttvcardsearch.rb
url "https://github.com/BlackIkeEagle/muttvcardsearch/archive/v1.9.tar.gz"
sha256 "4c099938dd02f577d8289bbc5e82f0af6f290a564a30f6fdcb5cc880cd02fc8d"

option "with-debug", "build debug version"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the advantage of this? We don't typical add debug options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I am aware of, I just carried it along, to be totally honest. I'll remove it.

@DomT4
Copy link
Member

DomT4 commented Jul 3, 2015 

        ==> brew style muttvcardsearch
== /usr/local/Library/Formula/muttvcardsearch.rb ==
C: 19:  5: Incorrect indentation detected (column 4 instead of 5).
C: 20:  3: Use 2 (not 3) spaces for indentation.

1 file inspected, 2 offenses detected

@benjaminfrank
Copy link
Contributor Author

Thanks, I couldn't view the Details yesterday.

@DomT4
Copy link
Member

DomT4 commented Jul 3, 2015

Yeah, we had some CI issues that persisted throughout yesterday. Sorry about the delay. You can hit the same audit input as the bot locally by doing brew audit --strict on the formula.

@benjaminfrank
Copy link
Contributor Author

I thought I did, that's why I was puzzled there is an error...(aka lazy me)

@benjaminfrank benjaminfrank force-pushed the muttvcard branch 2 times, most recently from 7c6a6af to cf585c7 Compare July 7, 2015 19:05
@DomT4
Copy link
Member

DomT4 commented Jul 13, 2015

@BrewTestBot test this please

DomT4
DomT4 reviewed Jul 16, 2015
View reviewed changes
Library/Formula/muttvcardsearch.rb
mkdir "build" do
system "cmake", "..", *std_cmake_args
system "make", "install"
bin.install "muttvcardsearch"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the CMakeList not installing this, even with your patch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad. Fixed it.

@benjaminfrank
New formula: muttvcardsearch 1.9
e06ddc6 
A small mutt carddav search utility for your Owncloud or SOGo server.
@benjaminfrank
Copy link
Contributor Author

Upstream seems pretty much inactive to incorporate the cmake fix. But then I am no longer using this software anyway.

@DomT4
Copy link
Member

DomT4 commented Sep 4, 2015

Alright, let's pass on this if upstream haven't responded to the patch PR and the software is no longer being used by you. Thanks for the submission though! ❤️

@DomT4 DomT4 closed this Sep 4, 2015
@benjaminfrank benjaminfrank deleted the muttvcard branch September 21, 2015 18:09
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
new formula
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benjaminfrank @DomT4 @MikeMcQuaid @bfontaine