Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Make audit recognise head-only and devel-only in all taps #41289

Closed
wants to merge 2 commits into from
Closed

Make audit recognise head-only and devel-only in all taps #41289

wants to merge 2 commits into from

Conversation

rkrug
Copy link
Contributor

@rkrug rkrug commented Jul 2, 2015

  • add wildcard into expressions to identify head-only and dev-only
    taps to avoid "head-only" and "devel-only" errors when recipie is in
    *head-only or *devel-only tap

@rkrug
Make audit recognise hed-only and devel-only in all taps
de7d2dd 
- add wildcard into expressions to identify head-only and dev-only
  taps to avoid "head-only" and "devel-only" errors when recipie is in
  *head-only or *devel-only tap
@rkrug rkrug changed the title Make audit recognise hed-only and devel-only in all taps Make audit recognise head-only and devel-only in all taps Jul 2, 2015
@rkrug
Copy link
Contributor Author

rkrug commented Jul 2, 2015

This one is working and tested locally.

@dunn
Copy link
Contributor

dunn commented Jul 2, 2015

Looks like you accidentally committed a patch file too.

@rkrug
Copy link
Contributor Author

rkrug commented Jul 2, 2015

Envoyé de mon iPhone

Le 2 juil. 2015 à 18:14, Alex Dunn notifications@github.com a écrit :

Looks like you accidentally committed a patch file too.

True - sorry.

—
Reply to this email directly or view it on GitHub.

MikeMcQuaid
MikeMcQuaid reviewed Jul 7, 2015
View reviewed changes
Library/Homebrew/cmd/audit.rb
@@ -421,11 +421,11 @@ def audit_homepage
end

def audit_specs
if head_only?(formula) && formula.tap.to_s.downcase != "homebrew/homebrew-head-only"
if head_only?(formula) && formula.tap.to_s.downcase !~ /.*head-only/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/-head-only/ should be enough here, I believe.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jul 7, 2015
Closed
@MikeMcQuaid
Copy link
Member

@Homebrew/owners I think I prefer this approach to #41413 and I think given there's a few tap authors asking for this we should merge something.

@jawshooah
Copy link
Contributor

@MikeMcQuaid This would require any head-only or devel-only formulae to be split into separate taps, right?

So in my case (#41413), I would need to create new taps for homebrew-pyenv-head-only and homebrew-nodenv-head-only, and migrate formulae accordingly. This adds maintenance overhead for me, and requires anyone using my formulae to tap an additional repo.

@MikeMcQuaid
Copy link
Member

@jawshooah Yes, they would. head-only provides a fairly shoddy user experience in Homebrew currently, unfortunately, and audit checks for that for that reason.

@jawshooah
Copy link
Contributor

Makes sense. It's probably a good convention to follow anyway, so that a user can confidently brew install any formulae in a tap not explicitly labeled as head/devel-only.

Shall I close the other PR, or would you like to wait for input from other maintainers?

@MikeMcQuaid
Copy link
Member

@jawshooah Thanks for understanding. Let's wait for input for now. Long-term I'd love to see HEAD install doing something smart using git describe or the Subversion revision number to calculate a 123-HEAD version or something.

@DomT4
Copy link
Member

DomT4 commented Jul 7, 2015

A while back I threw together a rough idea of storing the .git or .svn folders for the HEAD clone in the formula's prefix, and then running git pull or similar with each brew upgrade, but I suspected from having a bunch of stuff locally I pull at the same time the performance impact would have sucked so I dropped it.

Theoretically we could handle the performance hit by making people specify they wanted to update/upgrade their installed HEAD formulae 🐙.

@jawshooah
Copy link
Contributor

Yeah, this issue has been discussed at length in #13197. The problems with HEAD upgrades haven't changed, unfortunately.

Perhaps brew upgrade --HEAD could skip over formulae with non-VCS head urls?

@rkrug
Fixes
9a1c737 
* removed patch file
* replaced /-*devel-only/ with /-head-only
* replaced /-*devel-only/ with /-devel-only
@rkrug
Copy link
Contributor Author

rkrug commented Jul 8, 2015

I just committed the required changes. Let me know if you would prefer a clean pull request with only one commit.

woodruffw pushed a commit to woodruffw-forks/homebrew that referenced this pull request Jul 22, 2015
@rkrug @woodruffw
audit: recognise head-only and devel-only taps.
7d159f6 
add wildcard into expressions to identify head-only and dev-only taps
to avoid "head-only" and "devel-only" errors when formula is in
*head-only or *devel-only tap

Closes Homebrew#41289.
Closes Homebrew#41413.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
@jawshooah jawshooah mentioned this pull request Nov 8, 2015
Merged
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rkrug @dunn @MikeMcQuaid @jawshooah @DomT4