mono: Fix compile/runtime error on El Cap Beta 3 #41537
Conversation
|
Is there a reason that the brew test-bot is requesting access to my github account's associated organizations and it's repos when I click on the Details or build result links? |
|
We have it set at the least amount of permissions we're told the plugins require, I believe. CC @MikeMcQuaid |
|
You, sir, are a life saver. |
|
The only thing it requests is to see what organisation teams you're a member of (to see if you're in the Homebrew owners team). |
|
@MikeMcQuaid Thanks for the clarification. I thought it was requesting access to organization repos. |
|
@jonlbauer The compile will fail if there is an unfixed version of mono in your path. In the normal update case the old homebrew version is unlinked before the compile is started, so that's not an issue. But if you have multiple mono versions installed that might be the problem. |
|
@jonlbauer I think you can install from a url, try |
| @@ -14,6 +15,10 @@ class Mono < Formula | |||
| sha256 "80bddaefcd9c136bc763797cff98f3aa07ec758e348037fd24f07d2b1b795fbb" => :mountain_lion | |||
| end | |||
|
|
|||
| # Fix compile and runtime error on OS X 10.11 Beta 3 | |||
| # See: https://github.com/mono/mono/pull/1919 | |||
| patch :DATA | |||
There was a problem hiding this comment.
Please use https://github.com/mono/mono/pull/1919 as the patch URL, thanks!
There was a problem hiding this comment.
I didn't think of that. I'll push a new rev, thanks!
|
@jonlbauer You could install homebrew, uninstall your current mono and install using the command posted above or using |
This fixes the error "could not discover the mach TLS offset" which prohibits both running and compiling mono on OS X 10.11 (15A216g). The patch was backported from current mono/mono master. Because the problem also affects binaries compiled before upgrading to El Capitan the patch is *not* scoped to `MacOS.version >= :el_capitan`.
felixbuenemann
force-pushed
the
fix-mono-el-cap-tls-offset
branch
from
4bc469f
to
82fd9f2
Compare
|
Pushed a new commit to address @MikeMcQuaid's feedback. |
|
Thanks @felixbuenemann! |
|
FYI, you may also want to include the x86 patch for the same problem: # and for x86
patch do
url "https://github.com/mono/mono/pull/1924.diff"
sha256 "62e9d2ad134558c3fcf9c75e260c6091e390b23b4f320e79184136b76c021a39"
end |
|
@bosmacs Is there a case where mono would compile as x86 on El Cap? |
|
I thought it might affect code generation for 32-bit assemblies, but in brief testing that appears not to be the case. So perhaps it’s not needed after all. |
This fixes the error "could not discover the mach TLS offset" which
prohibits both running and compiling mono on OS X 10.11 (15A216g).
The patch was backported from current mono/mono master. Because the
problem also affects binaries compiled before upgrading to El Capitan
the patch is not scoped to
MacOS.version >= :el_capitan.See Xamarin Bugzilla Bug 31761 and PR mono/mono#1919 for more info.