mycli 1.0.0 (new formula) #42149
mycli 1.0.0 (new formula) #42149
Conversation
| url "https://pypi.python.org/packages/source/m/mycli/mycli-1.0.0.tar.gz" | ||
| sha256 "4d9258440b3a569066dc3c74a29d787bf89b0914aace080e6baa7dbf7ddb5f40" | ||
|
|
||
| bottle do |
There was a problem hiding this comment.
Please don't pre-add bottle blocks to new formula.
|
Thank you for the feedback. I've removed the bottle block and added a blank line between the last end and the start of the def install. Let me know if you have any other feedback. |
|
Is there more work that is needed on this PR? |
|
Is there anything I can do to make this PR easy to merge or review? Waiting on the merge to announce the app. /cc @DomT4 |
|
@tdsmith Would you mind reviewing this PR and merging? You were the one shepherded the pgcli formula and this is very a similar formula. Thank you! |
| end | ||
|
|
||
| test do | ||
| system bin/"mycli", "--help" |
There was a problem hiding this comment.
Can’t we use something more elaborated than --help?
There was a problem hiding this comment.
Since this app is an interactive client to a database, it is not possible to do a more elaborate test.
Doing an elaborate test will require knowing about a database instance and having access to a specific database.
But doing the --help should exercise the app and it's dependencies that are installed on the system.
|
Will take this, but please note pinging maintainers for review/merge so soon after the PR is created is frowned upon - new formulae PRs are allowed to sit for a few days so that any maintainer that wants to look over it has the time to do so. Merged in d1cdc52. Thank you for your contribution to Homebrew, we appreciate it! |
|
Thank you for accepting the formula. I would have preferred to know what was going on or how long it would take to come to a decision. |
|
Feel free to ping a ticket after a week or so. Thanks for submitting! |
mycliis a python application. It is a command line application to interact with MySQL database.This is not a python library, but it's an application that happens to be written in Python.
The best installation test for mycli is to invoke it with the
--helpoption. Which exercises all the libraries used by the app, which will be a robust test to see if all the dependencies are installed correctly.