Add img2xterm formula #43525
Add img2xterm formula #43525
Conversation
| desc "Display images on terminal" | ||
| homepage "https://github.com/kfei/img2xterm" | ||
| head "https://github.com/kfei/img2xterm.git" | ||
| url "https://github.com/kfei/img2xterm/archive/master.tar.gz" |
There was a problem hiding this comment.
We need a versioned tarball, otherwise the SHA won't match as soon as another commit is pushed. If you can't convince the developers to tag a release, we'll need to send this to our head-only repository instead.
There was a problem hiding this comment.
|
Also, the readme says it started as a fork of https://github.com/rossy/img2xterm; that repository meets our notability requirements. Is there a reason you didn't use @rossy's version? |
|
This project uses a custom, non-free license; we should probably warn the user of that on installation. def caveats; <<-EOS.undent
We agreed to the strongest public license for you.
If you cannot appreciate Cirno as the strongest in Gensokyo,
you should uninstall.
EOS
end |
|
The license makes me wary of inclusion, to be honest. |
|
It seems harmless, I'm happy to include it with a notice to the end user. |
|
Assuming we point it at the original repo and get a stable release, anyway. |
|
My worry is that it is legally non-free and that by consequence unless the maintainers as a whole accept the mightiness of Cirno we may not legally have the right to distribute the bottles, but I guess there's precedent for accepting licenses on behalf of users and I can't imagine we'll get bitten by this. |
|
The Fedora guys had the same issue (rossy/img2xterm#7.) It's CC0 now, so you should be able to use it without expressing your preference in touhous. Ping @kfei, since I suppose they can update their license too now. |
|
Thanks very much! Would you mind tagging a stable release? |
|
Done! img2xterm was one of my first C programs, and there's a lot of stuff I want to change. I guess the current version can be 1.0.0, and any future versions will be 2.0+. |
|
✨ Thanks so much! |
|
@rossy Thank you! |
|
@rossy Thanks! It was such a hilarious license though 😄 |
| version "1.0" | ||
|
|
||
| depends_on "pkg-config" => :build | ||
| depends_on 'imagemagick' |
|
Ping? |
|
Closing as dead. Please feel free to resubmit as fresh with the comments above addressed, if you'd like to. Thanks for the submission to Homebrew! |
"img2xterm" is a command line tool that converts images to a console friendly format. I didn't pick the name!