This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
node: update npm and add revision. #43537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,8 +32,8 @@ class Node < Formula | |||
| end | |||
|
|
|||
| resource "npm" do | |||
| url "https://registry.npmjs.org/npm/-/npm-2.12.1.tgz" | |||
| sha256 "6b6512c6f9097da193dfe046053d6d0483b5c5658dc0a763c1ba5609b6bbc16c" | |||
| url "https://registry.npmjs.org/npm/-/npm-2.14.1.tgz" | |||
There was a problem hiding this comment.
Is this the version shipped with 0.12.7?
There was a problem hiding this comment.
We don't care really. npm moves faster than node but remains compatible with Node & itself (at least across the 2.x releases). We apply newer npm versions from time to time for important fixes. I'm fine accepting this because there's a security issue in play, but we should use 2.14.2 instead.
|
Duly updated. |
|
Merged in 562a5b1. Thank you for your contribution to Homebrew, we appreciate it! 😺 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.