Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

python-markdown 2.6.5 (new formula) #47958

Closed
wants to merge 1 commit into from
Closed

python-markdown 2.6.5 (new formula) #47958

wants to merge 1 commit into from

Conversation

alexbarton
Copy link
Contributor

Add the Python "markdown" package, including the "markdown_py" binary.

Name the formular "python-markdown" to follow the Debian naming scheme:
https://packages.debian.org/search?searchon=contents&keywords=markdown_py

Signed-off-by: Alexander Barton alex@barton.de

@alexbarton
Copy link
Contributor Author

If I understand the Jenkins log correctly, the failed "default" test is not a problem of this Formula, right?

Or can I do something about it?

@bfontaine
Copy link
Contributor

No it’s a Jenkins issue.

@bfontaine
Copy link
Contributor

@BrewTestBot test this please.

url "https://pypi.python.org/packages/source/M/Markdown/Markdown-2.6.5.tar.gz"
sha256 "8d94cf6273606f76753fcb1324623792b3738c7612c2b180c85cc5e88642e560"

depends_on :python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be depends_on :python if MacOS.version <= :snow_leopard

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the Formular accordingly, thanks!

@dunn
Copy link
Contributor

dunn commented Jan 12, 2016

What's the benefit of installing this via Homebrew rather than pip?

@alexbarton
Copy link
Contributor Author

@dunn: If I use pip, the packages are installed to /Library/Python/2.7/site-packages, which requires root privileges. And because I didn't find an easy way to tell pip to install to /usr/local (without creating configuration files and adjusting the environment), I thought using Homebrew would be a good idea? No?

depends_on :python if MacOS.version <= :snow_leopard

def install
ENV.prepend_create_path "PYTHONPATH", lib/"python2.7/site-packages"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer for this to be sandboxed in libexec, really.

ENV.prepend_create_path "PYTHONPATH", libexec/"lib/python2.7/site-packages"

@tdsmith is free to disagree with me though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we went down this route you'd want to also use similar syntax to jrnl around bin.install and the env scripting.

@dunn
Copy link
Contributor

dunn commented Jan 12, 2016

Oh yeah, I forgot the pip installed with the system Python requires sudo. That's a good enough reason for me, then.

@MikeMcQuaid
Copy link
Member

Oh yeah, I forgot the pip installed with the system Python requires sudo. That's a good enough reason for me, then.

You can actually do pip install --user or something similar. I'm also wondering what advantage the markdown_py binary gives over other Markdown implementations in Homebrew; isn't this mainly useful as a library?

@alexbarton
Copy link
Contributor Author

@MikeMcQuaid I have 3rd party projects and inhouse tools depending on the markdown_py binary.

@tdsmith
Copy link
Contributor

tdsmith commented Jan 12, 2016

For consistency, it seems like this should only expose the command line script (i.e. the site-packages should end up under libexec like Dom suggested) or it should be in the homebrew-python tap. I'd prefer the former, I think, though it will be confusing that python-markdown does not install an importable python module.

Add the Python "markdown" package, including the "markdown_py" binary.

Name the formular "python-markdown" to follow the Debian naming scheme:
<https://packages.debian.org/search?searchon=contents&keywords=markdown_py>

Signed-off-by: Alexander Barton <alex@barton.de>

python-markdown: Install site-packages into libexec directory
@alexbarton
Copy link
Contributor Author

@tdsmith I updated the Formula accordingly. Is that what you meant by "should end up unter libexec"?

@MikeMcQuaid
Copy link
Member

Thanks @alexbarton!

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants