rswift 1.1.1 (new formula) #48357
rswift 1.1.1 (new formula) #48357
Conversation
| class Rswift < Formula | ||
| desc "Get strong typed, autocompleted resources like images, fonts and segues" | ||
| homepage "https://github.com/mac-cain13/R.swift" | ||
| url "https://github.com/mac-cain13/R.swift.git", :tag => "v1.1.1", :revision => "3a6db62164d8f50ccdf43e59894fffb672fd5e3f" |
There was a problem hiding this comment.
Please wrap this on multiple lines:
url "...",
:tag => "...",
:revision => "..."
|
thanks for your feedback @bfontaine |
|
@bfontaine looks like jenkins reported a false negative. what do I need to do? |
|
Tested successfully in |
|
@tomasharkema You can’t do anything about that, unfortunately. |
| end | ||
|
|
||
| test do | ||
| system "rswift", "-h" |
There was a problem hiding this comment.
Can’t we write a test that does something more substantial than e.g. -h/v? Also, use "#{bin}/rswift" instead of "rswift" to have the full path. Thanks!
There was a problem hiding this comment.
Good point @bfontaine, @tomasharkema asked me to take a look at the possibilities for a better test.
I think it’s a bit hard to really use the tool in a test, since that would need a valid iOS Xcode project. Creating a fixture for that would be a bit of a hassle I think.
The project itself tests if it output is correct using CI, so if we know that the binary is functional by executing it with a -h flag then I’m pretty sure everything is ok. I agree a test that actually uses the tool is better, but I think it’s not worth the hassle and maintenance in this case.
Also, I noted some other tools also use this kind of tests, so it seems like a good fallback to me.
There was a problem hiding this comment.
Sorry for the delay. If it’s too hard to create a resource for this it’s fine as is. Just replace "rswift" with "#{bin}/rswift".
There was a problem hiding this comment.
this is a outdated diff. please take a look at https://github.com/Homebrew/homebrew/pull/48357/files#diff-4423a6e9c87af8ea0a4fde1153e9e147R16
| url "https://github.com/mac-cain13/R.swift.git", | ||
| :tag => "v1.1.1", | ||
| :revision => "3a6db62164d8f50ccdf43e59894fffb672fd5e3f" | ||
| depends_on :xcode => "7.0" |
There was a problem hiding this comment.
Please leave an empty line between the :revision and first depends_on, Thanks!
…his issues in the future :)
|
@DomT4 Thanks for your comment. I've fixed it. I took the liberty to also adjust the audit script in such a way that your previous comments on my code are checked for by the audit command in the future. |
| @@ -647,6 +647,10 @@ def audit_text | |||
| Please add ENV.prepend_path \"PATH\", \"#{need_npm}"\ to def install | |||
| EOS | |||
| end | |||
|
|
|||
| if text =~ /=>.*[^,\n]\n[^\n].*/ | |||
There was a problem hiding this comment.
This would match quite a lot of legitimate stuff, e.g.:
def install
bin.install "foo" => "bar"
end
|
@tomasharkema Thank you for taking the time to improve the audit rules. However you might want to do that in a separate PR so that this one can be focused on |
…revent this issues in the future :)" This reverts commit bcc0939.
|
@bfontaine you're totally right. i've reverted the changes on |
|
@bfontaine do you agree with @mac-cain13 's remark about the test? |
|
Thank you @tomasharkema for your contribution to Homebrew; we appreciate it! 🎉 |
Closes Homebrew#48357. Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
Previous pr got a little bit messed-up, so i've reissued a PR with one tidy commit.
This adds the R.swift binary (from https://github.com/mac-cain13/R.swift) to brew. We got this request form multiple Cartage users.