Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

libvirt-glib 0.2.3 (new formula) #48860

Closed
wants to merge 1 commit into from

Conversation

vicamo
Copy link

@vicamo vicamo commented Feb 5, 2016

Signed-off-by: You-Sheng Yang (楊有勝) vicamo@gmail.com


# work around ld not understanding --version-script argument
# upstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1304981
patch :DATA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see this accepted by upstream before we include this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that has been accepted by upstream, then we don't need this, do we? So why not "for libvirt-glib 0.2.3 and maybe a few furture releases, we need this", and drop the patch when upstream has finally included a fix for Mac OS X. You must know it could take years before the patch for a unsupported platform makes its way into upstream trunk.

@vicamo
Copy link
Author

vicamo commented Feb 6, 2016

Moved into Library/Formula/libvirt-glib.rb

@vicamo
Copy link
Author

vicamo commented Feb 6, 2016

Fix typo.

@vicamo
Copy link
Author

vicamo commented Feb 6, 2016

Address style nits.

Signed-off-by: You-Sheng Yang (楊有勝) <vicamo@gmail.com>
@vicamo
Copy link
Author

vicamo commented Feb 6, 2016

Fix missed dep to glib.

@apjanke apjanke modified the milestone: Clear out Legacy May 3, 2016
@apjanke
Copy link
Contributor

apjanke commented May 3, 2016

@BrewTestBot test this please

@MikeMcQuaid
Copy link
Member

Passing on this as-is, please reopen on https://github.com/homebrew/homebrew-core if desired and when the patch is submitted and accepted upstream.

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants