Conversation
|
||
# work around ld not understanding --version-script argument | ||
# upstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1304981 | ||
patch :DATA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see this accepted by upstream before we include this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that has been accepted by upstream, then we don't need this, do we? So why not "for libvirt-glib 0.2.3 and maybe a few furture releases, we need this", and drop the patch when upstream has finally included a fix for Mac OS X. You must know it could take years before the patch for a unsupported platform makes its way into upstream trunk.
f4b7e9d
to
5e2da15
Compare
Moved into |
5e2da15
to
ab33b99
Compare
Fix typo. |
ab33b99
to
fd6b8e5
Compare
Address style nits. |
Signed-off-by: You-Sheng Yang (楊有勝) <vicamo@gmail.com>
fd6b8e5
to
15156a4
Compare
Fix missed dep to glib. |
@BrewTestBot test this please |
Passing on this as-is, please reopen on https://github.com/homebrew/homebrew-core if desired and when the patch is submitted and accepted upstream. |
Signed-off-by: You-Sheng Yang (楊有勝) vicamo@gmail.com