Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

jo 1.0 #50074

Closed
wants to merge 1 commit into from
Closed

jo 1.0 #50074

wants to merge 1 commit into from

Conversation

ear
Copy link
Contributor

@ear ear commented Mar 13, 2016

A small utility to create JSON objects from the command line. Kind of an inverse to jq. ☺️

@ear ear mentioned this pull request Mar 13, 2016
Closed
MikeMcQuaid
MikeMcQuaid reviewed Mar 13, 2016
View reviewed changes
Library/Formula/jo.rb
end

def install
system("autoreconf", "-i") if build.head?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can skip the parens here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ear
Copy link
Contributor Author

ear commented Mar 13, 2016

What is the polite/right way to handle the commits here? I.e. should I squash them?

@dunn
Copy link
Contributor

dunn commented Mar 13, 2016

I.e. should I squash them?

Yes, please!

@ear
Copy link
Contributor Author

ear commented Mar 13, 2016

Done! Thanks @dunn

@dunn
Copy link
Contributor

dunn commented Mar 13, 2016 

Error: 1 problem in 1 formula

==> audit problems
jo:
 * GitHub repository too new (<30 days old)

It's a pretty popular project, though, so I won't object if another maintainer merges this before the 30 days are up.

@jpmens jpmens mentioned this pull request Mar 13, 2016
Closed
@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

For future reference the preferred commit message format for new formulae is jo 1.0 (new formula). Please complete the issue template in future PRs where this format is detailed in the linked Contributing guidelines. Thanks!

xu-cheng pushed a commit to Homebrew/homebrew-core that referenced this pull request Mar 14, 2016
@ear @xu-cheng
jo 1.0 (new formula)
e95b2f3 
Closes Homebrew/legacy-homebrew#50074.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
new formula
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ear @dunn @MikeMcQuaid @DomT4