Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Add distribute/easy_install to Python3 formula #5276

Closed

Conversation

joshuajabbour
Copy link
Contributor

I've added distribute inline to the Python3 formula, as discussed in pull request 4354.

In doing so, I updated the formula to match the 2.7.1 as closely as possible. Caveats:

  • "allow sqlite3 module to load extensions" from 2.7.1 causes the build to break
  • "--no-poll" parameter from 2.7.1 -- I figured this could be added separately
  • "--with-computed-gotos" from 3.2 -- I don't know if this should be back-ported

Those are the only major discrepancies. All in all, it might make a lot of sense to combine these two formulae and switch versions based on a parameter. Not sure if that's done in Homebrew, but there's a ton of duplicated code here.

/cc @adamv

* Previous versions of the Python formula did not set up the
  site-packages and install-scripts folders in a way friendly
  to updates of Python itself.
* Add Distribute inline to replace stand-alone formula.
@robdennis
Copy link

Switching to Homebew from MacPorts, and had assumed that Python3 had already included the distribute/easy_install until noticing this pull request. It makes a lot of intuitive sense and I'd be in favor of this change.

@joshuajabbour
Copy link
Contributor Author

Yeah, I'm not sure if this will get in… looks like the Python3 formula has been updated outside this issue. Ultimately, I'm a fan of having one that installs both 2&3 based on a parameter, but unifying them like I did here is a nice first step.

@adamv
Copy link
Contributor

adamv commented Jul 7, 2011

We're not going to unify the 2 & 3 formulae (sorry) since it is very possible to install both side-by-side and having a unified formula would preclude that.

@joshuajabbour
Copy link
Contributor Author

Why would it? Maybe I don't understand fully how Formulae work, but couldn't you just run it twice (once each with different params) to install both? Just seems better than maintaining two duplicate scripts that quickly get (and are already) out of sync.

@adamv
Copy link
Contributor

adamv commented Jul 8, 2011

If you tried to run it a 2nd time it would say "already installed"

@adamv
Copy link
Contributor

adamv commented Sep 1, 2011

Added in f6a23ed

@adamv adamv closed this Sep 1, 2011
simeonwillbanks pushed a commit to simeonwillbanks/homebrew that referenced this pull request Oct 30, 2013
Based substantially on a patch by @joshuajabbour

See: Homebrew#5276
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants