Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

download_strategy.ry: Fix CVSDownloadStrategy #8873

Closed
wants to merge 1 commit into from

Conversation

ColinHebert
Copy link
Contributor

The FileUtils.cp_r function with a wildcard doesn't copy hidden files (starting with a dot)
Instead of copying everything selected by *, select all the folder content

The FileUtils.cp_r function with a wildcard doesn't copy hidden files (starting with a dot)
Instead of copying everything selected by *, select all the folder content
@adamv
Copy link
Contributor

adamv commented Dec 3, 2011

Is there some documentation on this?

@ColinHebert
Copy link
Contributor Author

Well, the "rm" command on a UNIX doesn't copy hidden files when you just use a wildcard.
The most explicit explanation is on the glob command : http://www.ruby-doc.org/core-1.9.3/Dir.html#method-c-glob

@jacknagel
Copy link
Contributor

Pulled with that link in the commit message.

@jacknagel jacknagel closed this in c28c3cb Feb 2, 2012
etehtsea pushed a commit to etehtsea/homebrew that referenced this pull request Feb 2, 2012
The FileUtils.cp_r function with a wildcard doesn't copy hidden files
(starting with a dot) Instead of copying everything selected by *,
select all the folder content.

See: http://www.ruby-doc.org/core-1.9.3/Dir.html#method-c-glob

Closes Homebrew#8873.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>

Conflicts:

	Library/Homebrew/download_strategy.rb
@adamv
Copy link
Contributor

adamv commented Feb 2, 2012

Should probably reference the 1.8.6 / 1.8.7 docs instead of 1.9.3.

Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Jun 18, 2012
The FileUtils.cp_r function with a wildcard doesn't copy hidden files
(starting with a dot) Instead of copying everything selected by *,
select all the folder content.

See: http://www.ruby-doc.org/core-1.9.3/Dir.html#method-c-glob

Closes Homebrew#8873.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
The FileUtils.cp_r function with a wildcard doesn't copy hidden files
(starting with a dot) Instead of copying everything selected by *,
select all the folder content.

See: http://www.ruby-doc.org/core-1.9.3/Dir.html#method-c-glob

Closes Homebrew#8873.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants