Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Wine upgraded to 1.5.22 #17185

Closed
wants to merge 1 commit into from
Closed

Wine upgraded to 1.5.22 #17185

wants to merge 1 commit into from

Conversation

dholm
Copy link
Contributor

@dholm dholm commented Jan 19, 2013

This version includes the new experimental Mac driver which means it can be
run without X11. As the driver is still incomplete and buggy X11 is still the
default and instructions on how to switch are included in caveats.

libpng, libtiff, little-cms and xz (liblzma) are modified to always build as
universal binaries like the jpeg and libicns packages already do. These
changes are required if wine is to be able to use them for 32-bit windows
applications.

@adamv
Copy link
Contributor

adamv commented Jan 19, 2013

We're not going to make everything install universal; there is other work going on to improve the "this needs a universal dep" story.

@adamv
Copy link
Contributor

adamv commented Jan 19, 2013

Please repost a pull request with only the version updates.

@dholm
Copy link
Contributor Author

dholm commented Jan 19, 2013

I suspected that would be the answer. Is there a ticket I can track for it?

@adamv
Copy link
Contributor

adamv commented Jan 19, 2013

#14456 #14009 as well as #14550 and #15478.

@cooljeanius
Copy link

We're not going to make everything install universal;

Could that at least be an option for those that want it?

Edit: nvm I probably should have actually read the patch first before responding

@dholm
Copy link
Contributor Author

dholm commented Jan 19, 2013

It is an option but you have to manually (re)install all the dependencies with '--universal' and then (re)build wine.

@dholm
Copy link
Contributor Author

dholm commented Jan 27, 2013

Added support for non-universal builds as well as universal dependency checking thanks to #14456.

@jacknagel
Copy link
Contributor

Even the => :universal bits are superfluous, it will be passed automatically if the dependent formula supports it and the user requests it.

@dholm
Copy link
Contributor Author

dholm commented Jan 27, 2013

Oh, awesome, fixed!

@camillol
Copy link
Contributor

What is "build32" doing now? Is Wine 64 bit supposed to be working on Mac now?

@adamv
Copy link
Contributor

adamv commented Jan 31, 2013

Needs to be rebased to just have the Wine update; I've updated libicns and jpeg to make --universal an option.

This version includes the new experimental Mac driver which means it can be
run without X11. As the driver is still incomplete and buggy X11 is still the
default and instructions on how to switch are included in caveats.

Also, supports building a non-universal binary (i.e. only win64) support and
checking for universal dependencies thanks to Homebrew#14456.
@dholm
Copy link
Contributor Author

dholm commented Jan 31, 2013

Done

@adamv adamv closed this in 7a80519 Jan 31, 2013
@camillol
Copy link
Contributor

camillol commented Feb 3, 2013

I really doubt that "you will only be able to run applications built for win64!" if you don't build with --universal. First, I still see no indication that 64-bit wine is supported on Mac at all. Second, we're forcing a 32-bit build anyway.

I think the formula should set --universal automatically, so that it gets the normal dependency effects, without having to specify it on the command line. Failing that, it should refuse to build without that flag.

@dholm
Copy link
Contributor Author

dholm commented Feb 3, 2013

I will change it when the next development release comes out.

@camillol
Copy link
Contributor

camillol commented Feb 3, 2013

It's out now. But is there a way to make this formula implicitly universal, so that the user can just type brew install wine --devel?

@dholm
Copy link
Contributor Author

dholm commented Feb 4, 2013

Yes, I just have to force the dependencies to universal and all the required packages support that now thanks to adamv.

@rtfmoz
Copy link

rtfmoz commented Feb 6, 2014

Can I revisit the 64 bit wine on OSX? I tried to compile using the --enable-win64 flags. Should I open a new feature request for this?

@adamv
Copy link
Contributor

adamv commented Feb 6, 2014

Open a new pull request if you get it working.

@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants