Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

archey is a GitHub fork #47167

Closed
apjanke opened this issue Dec 19, 2015 · 9 comments
Closed

archey is a GitHub fork #47167

apjanke opened this issue Dec 19, 2015 · 9 comments

Comments

@apjanke
Copy link
Contributor

apjanke commented Dec 19, 2015

The archey formula points to a GitHub fork.

It's not clear what the actual master repository should be, because this is a 5-deep fork chain that goes back to a half-empty repo (maybe just used to share a copy of a script?). Let's figure this out and see find what the actual master repo is.

$ brew audit --strict --online archey
==> brew style archey

1 file inspected, no offenses detected

==> audit problems
archey:
 * GitHub fork (not canonical repository)

Error: 1 problem in 1 formula

Formula points to https://github.com/obihann/archey-osx.

Fork chain:
https://github.com/obihann/archey-osx
forked from https://github.com/Gary00/OSXey
forked from https://github.com/joshfinnie/archey-osx
forked from https://github.com/teoljungberg/archey-osx
forked from https://github.com/onlythefinestwilldo/Quality.Junk

@apjanke
Copy link
Contributor Author

apjanke commented Dec 19, 2015

@obihann You've been active in this formula, and that's your repo at the head of the fork chain. Comments?

@DomT4
Copy link
Member

DomT4 commented Dec 19, 2015

I don't have any issue with pointing at the fork in this situation FWIW. It's where most people seem to go to find an Archey OS X clone that works now.

@apjanke
Copy link
Contributor Author

apjanke commented Dec 20, 2015

Okay. Is there something we can do to suppress the audit failure?

@DomT4
Copy link
Member

DomT4 commented Dec 20, 2015

Could add a formula specific return to the check, I guess. The long-term plan for a while has been a full audit whitelist, but I haven't got around to that particular horse yet.

@obihann
Copy link
Contributor

obihann commented Dec 21, 2015

Is their anything I can do on my end to help out here?

@apjanke
Copy link
Contributor Author

apjanke commented Dec 23, 2015

If you really wanted to fix this, you could de-forkify your repo. (I think that requires renaming the existing repo, creating a new one with the original name, and pushing your history to it from a local clone.)

Or you can just wait for us to figure out how to do audit whitelisting. It's not urgent: I just ran in to this while testing & auditing some stuff; no functionality is broken.

@MikeMcQuaid
Copy link
Member

If you really wanted to fix this, you could de-forkify your repo. (I think that requires renaming the existing repo, creating a new one with the original name, and pushing your history to it from a local clone.)

You can just ask GitHub to defork this, actually (and as I work there: I can do this for you).

Or you can just wait for us to figure out how to do audit whitelisting. It's not urgent: I just ran in to this while testing & auditing some stuff; no functionality is broken.

@apjanke We already do that; you can see in other cases we do early returns based on the formula name.

@obihann
Copy link
Contributor

obihann commented Jan 4, 2016

@MikeMcQuaid If you could defork my branch, that would be amazing. Thanks!

@MikeMcQuaid
Copy link
Member

https://github.com/obihann/archey-osx is now deforked. Thanks @apjanke and @obihann!

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants