Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Core/Formula Separation [Tracking Issue] #50650

Closed
34 of 35 tasks
apjanke opened this issue Apr 3, 2016 · 6 comments
Closed
34 of 35 tasks

Core/Formula Separation [Tracking Issue] #50650

apjanke opened this issue Apr 3, 2016 · 6 comments

Comments

@apjanke
Copy link
Contributor

apjanke commented Apr 3, 2016

This is a list of issues and commits related to the Homebrew Core/Formula Separation (#49752). It's done as an issue instead of a label because it will have items from multiple repos and will include annotations.

Relevant Repos

https://github.com/homebrew/homebrew - the original Homebrew repo
https://github.com/homebrew/homebrew-core - the new core formula tap
https://github.com/homebrew/brew - where the new brew package manager code will go in step 2

Posts and Announcements

Separation Work

Resulting Issues

Other Issues

  • brew doctor need to be updated to include both brew and homebrew-core repos origin check. At the same time, it may be a good idea to disable CoreTap auto-tap for brew doctor.
  • Homebrew/core Travis CI fails to test formula. Homebrew/core Travis CI fails to test formula. brew#100
@UniqMartin
Copy link
Contributor

Seems like everything is done except for “brew doctor need to be updated to include new repo check.”, that I don't understand. Can you explain what needs to be done here?

@apjanke
Copy link
Contributor Author

apjanke commented Apr 17, 2016

You know what; I heard that from @xu-cheng and I forgot exactly what it means. I think it just means to have doctor check that origin is pointing at the new repo.

I believe the current check_git_origin check (from d127569) now covers this, and we can tick it off and close this issue. Is that correct, Xu?

@xu-cheng
Copy link
Member

Yeah, I'm thinking we should add git origin check for both homebrew/brew and homebrew/core tap.

Another thing is we probably should stop hombrew/core auto-tap during brew doctor. Because it could introduce nasty error if users happen to have not installed git.

@apjanke
Copy link
Contributor Author

apjanke commented Apr 17, 2016

I think the git origin check for homebrew/brew is already there; we just need to add it for homebrew/core tap. (Sorry for broken link in my previous comment.)

Yeah. Maybe we should stop auto-tap of everything in brew doctor: besides the git error, as a diagnostic tool, I'd expect it to be "read-only".

@MikeMcQuaid
Copy link
Member

Another thing is we probably should stop hombrew/core auto-tap during brew doctor. Because it could introduce nasty error if users happen to have not installed git.

👍

@apjanke apjanke modified the milestone: Clear out Legacy May 3, 2016
@MikeMcQuaid
Copy link
Member

This was done ✨

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants