-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better scraping: switch to HTTPlug + Guzzle #24
Comments
|
If you want to manage your dependencies with Composer, like HTTPlug/Guzzle or else, you can use a scoper/prefixer like PHP-Scoper to automate the prefixing build task, as suggested here. It seems to be used by well-know popular plugins like Yoast etc... |
I hadn't heard of PHP-scoper thank you @mlang38 . Been using Composer in Drupal world a while however I don't have a clear sense of whether its a good solution for WP plugins (i suppose the plugin would be distributed with the build artifact version of it) |
PHP-Scoper works well once you learn to steer clear of some of its limitations. For an example configuration, see what I've done in wp-Typography (especially the |
Sweet thanks - looks like someone pulled your PHP library into drupal world also https://www.drupal.org/project/twig_typography ... gotta check em both out. |
It is not easy necessarily to include libraries from Composer, they may have to be manually namespaced.
See also #21 as this plugin will need a composer.json file as well to operate this correctly (and thus will need to know its namespace if it has the original or a new fork one)
Recommended by @mlang38 here:
The text was updated successfully, but these errors were encountered: