Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not edit pictures #332

Closed
heinzbloed opened this issue Sep 25, 2016 · 12 comments
Closed

can not edit pictures #332

heinzbloed opened this issue Sep 25, 2016 · 12 comments

Comments

@heinzbloed
Copy link

heinzbloed commented Sep 25, 2016

hi, thanks for developing open source software!

i can not edit photos, btw. can not save those changes.
i can see the changes, but if i come back to the gallery, the changes were lost/undo.

i got a special setup with omnirom 6.0.1 on a galaxy nexus without any google stuff.
maybe this is a problem (missing libs?)

i got a log with logcat while editing files, maybe you got an idea where i can search for solutions.
Thanks.

logcat_leafpic_edit_picture.txt

@dnldsht
Copy link
Member

dnldsht commented Sep 26, 2016

@heinzbloed with the new release when you edit an image it create a new file with the changes.

@touzainanboku
Copy link

@dnldsht have you pushed the new update to the Play Store?

@dnldsht
Copy link
Member

dnldsht commented Sep 26, 2016

@touzainanboku not yet, I'm figuring out some problems with donations via in app-purchase.
here is the link of the new version

EDIT: pushed on the playstore the new release, f-droid will take it automaticaly

@touzainanboku
Copy link

@dnldsht thanks for the DL link! And I wish you luck in fixing those issues.

@heinzbloed
Copy link
Author

thanks for your investigstion.
i'm only using f-droid so theres is the question who push the new version to f-droid...?
on previous test it seems that leafepic can copy files but can not rename files.
maybe this is a problem of masrshmallow aka aosp 6.X
i will donate your project, thanks!

@rugk
Copy link

rugk commented Sep 28, 2016

I also experience this error. Is the build already on FDroid? If so, which version?

@heinzbloed
Copy link
Author

the new Version is now in F-Droid, for me it works.
thx

@Bugsbane
Copy link

Bugsbane commented Oct 2, 2016

@dnldsht Are you aware of Google's"lovely" change in terms of services recently that ban donation links in apps unless they're using Google's in-app payment services (netting them 30% of your donation)?

Most other devs are doing separate versions for Google Play now without the donation links (or accepting that 30% goes to Google( and leaving them in, in Fdroid et al.

Don't be evil, my butt. :(

@dnldsht
Copy link
Member

dnldsht commented Oct 2, 2016

Thank you for warn me, I'm gonna read these terms and make some changes to
the donations.

BTW for every donation Google doesn't take 30% it get more: they took 30%
for every purchase and you have also to pay the vat and it depends from the
country. If somebody donate me 2€(2.39€) I receive something like 1.40€

On Sun, Oct 2, 2016, 8:14 PM Bugsbane notifications@github.com wrote:

@dnldsht https://github.com/dnldsht Are you aware of Google's"lovely"
change in terms of services recently that ban donation links in apps unless
they're using Google's in-app payment services (netting them 30% of your
donation)?

Most other devs are doing separate versions for Google Play now without
the donation links (or accepting that 30% goes to Google( and leaving them
in, in Fdroid et al.

Don't be evil, my butt. :(


You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#332 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFBzAJnwwEkPBJuAbawDeIrWOJJPOhCMks5qv_STgaJpZM4KF4Ew
.

@rugk
Copy link

rugk commented Oct 18, 2016

I think the current edit model is still not good. It only shows me a message that a new fully was created, but I cannot see the file right away. Instead I have to go or of the folder and go into it again.

This is still very bass UX. Please just show the edited file directly after saving the changes.

@rugk
Copy link

rugk commented Nov 28, 2017

Does this mean it is fixed/implemented or what?

@dnldsht
Copy link
Member

dnldsht commented Nov 28, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants