Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible privacy leakage due to ordered transaction inputs #383

Open
yixiao5428 opened this issue Jul 17, 2021 · 0 comments
Open

Possible privacy leakage due to ordered transaction inputs #383

yixiao5428 opened this issue Jul 17, 2021 · 0 comments

Comments

@yixiao5428
Copy link

This is a security vulnerability.
The wallet uses ordered inputs of transactions (src/wallet/wallet.cpp, line 2766 - 2772), which may incur privacy risks like fingerprinting the wallet to observers.

A possible solution is to clear the original order, shuffle it, and push back the new order before signing the transaction.

Similar fix from Bitcoin: bitcoin/bitcoin@2fb9c1e.

Reported by 6004ed5feaa31ae9df36b5dbc60f0fa53255a5fb734334082c6d202405fc738c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yixiao5428