Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to CI pipeline to ensure that ./lib is in sync with ./src #34

Closed
cronicc opened this issue Mar 17, 2020 · 16 comments · Fixed by #44
Closed

Add check to CI pipeline to ensure that ./lib is in sync with ./src #34

cronicc opened this issue Mar 17, 2020 · 16 comments · Fixed by #44
Assignees
Labels
bounty_paid_1 Bounty paid 1 time bounty_231 Bounty of 231 USD diff_advanced Some experience in software development is required HDE Adds issue to the HDE platform Help Wanted lang_js JavaScript knowledge required

Comments

@cronicc
Copy link
Member

cronicc commented Mar 17, 2020

98a7327 was forgotten in #32 requiring a force push to fix. Not the nice way to do it but the alternative would have been to do another release v1.2.4 for this simple change.

So for the future we need a check in the CI pipeline to ensure ./lib was regenerated before merging to master.

@cronicc cronicc self-assigned this Mar 17, 2020
@jtoownus
Copy link

jtoownus commented Jun 2, 2020

Is this still needed? Will add to the list of potential HDE go-live tasks if yes.

@angievi
Copy link

angievi commented Jun 9, 2020

will review this issue with Cronic tomorrow and let you know @jtoownus

@jtoownus jtoownus added diff_advanced Some experience in software development is required HDE Adds issue to the HDE platform bounty_10 Bounty of 10 USD lang_js JavaScript knowledge required labels Jul 6, 2020
@salvatoretrimarchi
Copy link

@angievi @jtoownus Can I help you with this? You are using Travis. Can you give me more details. /
Puedo ayudarles con esto?, estan usando Travis. Me pueden dar mas detalles.

@hamido007
Copy link

hey @salvatoretrimarchi
that would be cool if you help me concerning Travis and the issues im not familiar to travis

@cemgulvfx
Copy link

I can`t reached Travis Cl connection. Can you double check.

@jonahion
Copy link
Contributor

Hello, I'd like to help with this issue if it's still open?
I'd suggest to do the check in a git hook as well so that, unless skipped with the -n flag, it gives a quick feedback

@jonahion
Copy link
Contributor

@angievi @jtoownus, I have implemented the check in #41
Please review

@angievi
Copy link

angievi commented Sep 30, 2020

Hello! @jonahion , we will review and come back to you with an answer, in the mean time, thanks for your contribution!
Angie.

@Ukyithar
Copy link

Ukyithar commented Oct 1, 2020

How do use?

@Ukyithar Ukyithar mentioned this issue Oct 1, 2020
@Ukyithar
Copy link

Ukyithar commented Oct 1, 2020

will review this issue with Cronic tomorrow and let you know

@jonahion
Copy link
Contributor

jonahion commented Oct 1, 2020

cool, thank you both for the update :)

@jonahion
Copy link
Contributor

jonahion commented Oct 2, 2020

Please review #44 instead of #41
Declined the latter due to git history rewriting gone too far ;)

@jonahion
Copy link
Contributor

Hi @angievi, thanks for your previous reply :)
Is there anything in the PR that needs improvement or explanation?

@angievi
Copy link

angievi commented Jan 8, 2021

@jonahion nothing needed, the request for the bounty to be paid was sent. it should arrive soon.

thanks for contributing to HDE! :)

@jonahion
Copy link
Contributor

@angievi, that's great, thanks!
it was a pleasure :)

@cronicc cronicc added bounty_231 Bounty of 231 USD bounty_paid_1 Bounty paid 1 time and removed bounty_10 Bounty of 10 USD labels May 7, 2021
@QAWSED4455
Copy link

Do it , great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty_paid_1 Bounty paid 1 time bounty_231 Bounty of 231 USD diff_advanced Some experience in software development is required HDE Adds issue to the HDE platform Help Wanted lang_js JavaScript knowledge required
Projects
None yet
9 participants