This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Renaming for testnet release #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 8, 2021 17:14
The following commands have been renamed: sc_create => dep_sc_create create_sidechain => sc_create
The following commands have been renamed: sc_send => dep_sc_send send_to_sidechain => sc_send
The following RPC commands have been renamed: request_transfer_from_sidechain => sc_request_transfer
The following commands have been renamed: send_certificate => sc_send_certificate
The following JSON fields have been renamed: "withdrawal epoch length" => "withdrawalEpochLength" "backward transfer" => "backwardTransfer"
This was
linked to
issues
Sep 8, 2021
| @@ -173,7 +173,7 @@ def run_test(self): | |||
|
|
|||
| try: | |||
| # The send_certificate call must be ok since the proof verification is disabled on node 2 | |||
There was a problem hiding this comment.
You forgot to update the comment ->"sc_send_certificate"
DanieleDiBenedetto
approved these changes
Sep 8, 2021
cronicc
changed the base branch from
sidechains_integration_code_review
to
testnet_staging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following RPC commands have been renamed:
Additionally, the following RPC JSON fields have been renamed:
This PR closes #158 #159 #160 #166.