Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Bottom-Navigation-Bar #5

Merged
merged 1 commit into from Oct 9, 2021
Merged

added Bottom-Navigation-Bar #5

merged 1 commit into from Oct 9, 2021

Conversation

Hiten24
Copy link
Contributor

@Hiten24 Hiten24 commented Oct 9, 2021

#3

created Bottom navigation bar with jetpack compose

  • created empty screens for navigation
  • added navhost in Navigation.kt
  • created BottomNavigationItem

output:

@Horizon733 Horizon733 self-requested a review October 9, 2021 08:32
@Horizon733 Horizon733 added the enhancement New feature or request label Oct 9, 2021
Horizon733
Horizon733 approved these changes Oct 9, 2021
View reviewed changes
Copy link
Owner

@Horizon733 Horizon733 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for Contributing, Looks good to me. Will merge this after I test this locally

@Horizon733 Horizon733 merged commit d64de12 into Horizon733:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Horizon733 Horizon733 Horizon733 approved these changes

Assignees

@Hiten24 Hiten24

Labels
enhancement New feature or request hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hiten24 @Horizon733