Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #1

Merged
merged 1 commit into from Jan 7, 2022
Merged

minor fixes #1

merged 1 commit into from Jan 7, 2022

Conversation

marc1uk
Copy link
Contributor

@marc1uk marc1uk commented Jan 5, 2022

  • stray 'f' in print statement was throwing a syntax error
  • '{self.mac_address}' was just being printed as a literal string, rather than the actual address.
  • mode 'RGB' seemed to give varying results with transparent pngs - some would show transparent areas as black, others as white. Not sure why or what the difference was between the files - my image viewer showed both as transparent PNGs? Replacing with RGBA seemed to do the trick, though.

* stray 'f' in print statement was throwing a syntax error
* '{self.mac_address}' was just being printed as a literal string, rather than the actual address.
* mode 'RGB' seemed to give varying results with transparent pngs - some would show transparent areas as black, others as white. Not sure why or what the difference was between the files  - my image viewer showed both as transparent PNGs? Replacing with RGBA seemed to do the trick, though.
@HoroTW
Copy link
Owner

HoroTW commented Jan 6, 2022

Thank you for the fix - on the f string part: could you elaborate the issue? Do you use an old python version (pre 3.6 [december 2016])? I can not See why the f string would be a syntax error.

@marc1uk
Copy link
Contributor Author

marc1uk commented Jan 7, 2022

Hi HoroTW, you're right, i'm running an old python version (3.5.3) which falls over with this printf syntax. i'm not a python user, so didn't realise that was valid with newer python. Feel free to drop that from the commit... although perhaps if it works in newer pythons too, it's better for compatibility.

@HoroTW HoroTW merged commit 3893b0d into HoroTW:main Jan 7, 2022
@HoroTW
Copy link
Owner

HoroTW commented Jan 7, 2022

Merged it 🙂 - I reverted the print back to use the f-strings, I'm with you on the backwards compability but I wan't to be able to use other features from 3.6 and really like the f-string style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants