Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Sidebar should be collapsible so only icons show #1858

Closed
jackcmeyer opened this issue Feb 25, 2020 · 8 comments 路 Fixed by #1883
Closed

Sidebar should be collapsible so only icons show #1858

jackcmeyer opened this issue Feb 25, 2020 · 8 comments 路 Fixed by #1883
Assignees
Labels
馃殌enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on
Projects

Comments

@jackcmeyer
Copy link
Member

jackcmeyer commented Feb 25, 2020

馃殌 Feature Proposal

The sidebar should be collapsible so only the icons show to maximize screen space.

This should be a user controlled behavior with some sort of expand/collapse icon.

This should automatically happen when the screen becomes a smaller screen.

Motivation

The sidebar should be collapsible so only the icons show to maximize screen space.

Example

See #103 for a detailed discussion and some examples.

@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Feb 25, 2020
@jackcmeyer jackcmeyer added 馃殌enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions labels Feb 25, 2020
@rabbihossain
Copy link
Contributor

I think I can help with this. Should I start working on this?

@jackcmeyer
Copy link
Member Author

@rabbihossain I've assigned this issue to you! let anyone on @HospitalRun/core-maintainers know if you need any help!

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Mar 5, 2020
@rabbihossain
Copy link
Contributor

Thanks for assigning this to me. I have already started working on it. I will get back to you once I finish implementing it.

@rabbihossain
Copy link
Contributor

hello @jackcmeyer ,
I am almost done implementing this. here is a preview of how the sidebar collapse toggle works.

Peek 2020-03-05 18-43

Please let me know if you have any feedback. Should I make a pull request?

@jackcmeyer
Copy link
Member Author

This is awesome! Please open a PR 馃榾

@rabbihossain
Copy link
Contributor

@jackcmeyer, I am trying to make a pull request but when I run npm run commit (as it was written on the project readme document), it always fails on npm run test:ci step. Am I doing anything wrong?

@matteovivona
Copy link
Contributor

matteovivona commented Mar 5, 2020

@rabbihossain try to run this command:

  1. yarn
  2. yarn lint:fix
  3. yarn commit

@rabbihossain
Copy link
Contributor

thanks @tehkapa for helping me out. Looks like my changes broke some of the test cases. So I updated those test cases according to my changes. I also made a pull request.

Version 2.0 automation moved this from To do to Done Mar 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
馃殌enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on
Projects
Version 2.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants