Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Standardize mock store setup in tests #2062

Closed
jackcmeyer opened this issue May 11, 2020 · 3 comments 路 Fixed by #2075
Closed

Standardize mock store setup in tests #2062

jackcmeyer opened this issue May 11, 2020 · 3 comments 路 Fixed by #2075
Labels
good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Projects
Version 2.0
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

馃悰 Bug Report

In some cases, the mock store setup in tests are different. We should use createMockStore in all cases instead of `configureMocks
@jackcmeyer jackcmeyer added help wanted indicates that an issue is open for contributions good first issue indicates an issue is good for a first time contributor LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button) labels May 11, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone May 11, 2020
@ghost
Copy link

ghost commented May 14, 2020

@jackcmeyer Hi, may I take this one?

@matteovivona
Copy link
Contributor

@kumikokashii sure!

@matteovivona matteovivona assigned ghost May 14, 2020
@ghost ghost mentioned this issue May 14, 2020
Merged
@ghost
Copy link

ghost commented May 14, 2020

PR is ready for your review. Thank you! #2075

@jackcmeyer jackcmeyer added this to Done in Version 2.0 via automation May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions LOE - small indicates that the level of effort to complete issue is small (i.e changing the color of a button)
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

fix: standardize mock store setup in tests
2 participants
@matteovivona @jackcmeyer