feat(caregoal): add care goals to patient #2360
Conversation
|
|
jackcmeyer
added
patients
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/pdo7y54br |
| @@ -131,7 +131,7 @@ describe('ViewPatient', () => { | |||
| const tabs = tabsHeader.find(Tab) | |||
| expect(tabsHeader).toHaveLength(1) | |||
|
|
|||
| expect(tabs).toHaveLength(9) | |||
| expect(tabs).toHaveLength(10) | |||
There was a problem hiding this comment.
should also and a test to make sure it marks the tab as active when clicked
| expect(descriptionInput.prop('feedback')).toEqual(expectedError.description) | ||
|
|
||
| expect(prioritySelector.prop('isInvalid')).toBeTruthy() | ||
| // expect(prioritySelector.prop('feedback')).toEqual(expectedError.priority) |
There was a problem hiding this comment.
I think this commented out code should be tested. We should un-comment it and make sure the tests pass.
There was a problem hiding this comment.
I think there is no feedback prop on SelectWithLabelFormGroup component. Also has a coment there: "todo: add feedback in next round"
|
|
||
| wrapper.update() | ||
|
|
||
| return { wrapper } |
There was a problem hiding this comment.
Change to return { wrapper: wrapper as ReactWrapper } so we can get type support
| careGoal: Omit<CareGoal, 'id' | 'createdOn'> | ||
| } | ||
|
|
||
| async function addCareGoal(request: AddCareGoalRequest): Promise<CareGoal[]> { |
There was a problem hiding this comment.
there should be tests for this hook
There was a problem hiding this comment.
Yeah, I'd forgotten and then I did it on the lastest commit.
confirmed--doesn't work for me either |
|
Tks guys. I'll make those changes. |
There was a problem hiding this comment.
LGTM.
@jackcmeyer and @morrme are all comments addressed now?
Fixes #2080 .
Changes proposed in this pull request: