Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Build acceptance test for medication.completed #697

Closed
billybonks opened this issue Oct 2, 2016 · 4 comments
Closed

Build acceptance test for medication.completed #697

billybonks opened this issue Oct 2, 2016 · 4 comments
Assignees
Labels
help wanted indicates that an issue is open for contributions in progress indicates that issue/pull request is currently being worked on

Comments

@billybonks
Copy link
Contributor

In order to effectively use the no missing translations test, we need to make sure that every page is visited during acceptance tests.

This issue tracks the missing medication.completed acceptance test

for ember new commers the value some.route is the route that's missing you can find them under router.js

@billybonks
Copy link
Contributor Author

i will do this

@jkleinsc jkleinsc added help wanted indicates that an issue is open for contributions hacktoberfest labels Oct 10, 2016
@jscottchapman
Copy link
Contributor

@billybonks It looks like you are working on this one. Is that right? Just wanted to make sure two people aren't working on the same issue unknowingly.

@jkleinsc jkleinsc added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Oct 12, 2016
@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Mar 14, 2017
@baoqchau
Copy link
Contributor

Hello @jkleinsc, I would like to help with this issue. Can you show me how should I test this route? Thanks a lot.

@jkleinsc
Copy link
Member

@baoqchau you should be able to test this by modifying the fulfilling a medication request test here:
https://github.com/HospitalRun/hospitalrun-frontend/blob/master/tests/acceptance/medication-test.js#L66-L93

You can add checks in this test to check medication/completed before and after the medication request is fulfilled. Does that make sense?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted indicates that an issue is open for contributions in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

No branches or pull requests

6 participants