Public constructors for extension #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension was annotated with @rule instead of @RegisterExtension
massdosage
approved these changes
Nov 27, 2019
There was a problem hiding this comment.
@cmathiesen @patduin if one of you can also approve and then merge this and then raise a small PR for the changelog explaining the change we can then merge that and do a release.
cmathiesen
approved these changes
Nov 27, 2019
|
@mateoi BeeJU 3.0.1 has been released and will appear on Maven soon! Thank you for the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructors for HiveMetaStoreJUnitExtension and HiveServer2JUnitExtension are package-private, so they cannot be used outside the com.hotels.beeju.extensions package. This PR fixes that problem.