Skip to content

Commit

Permalink
typos and clarifications
Browse files Browse the repository at this point in the history
  • Loading branch information
Patrick Duin committed Aug 28, 2019
1 parent 851042f commit a977f25
Showing 1 changed file with 21 additions and 21 deletions.
42 changes: 21 additions & 21 deletions ...a/com/hotels/bdp/circustrain/avro/transformation/AbstractAvroSerDeTransformationTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public void setUp() {

@Test
public void testOneReplicationsOverride() throws Exception {
EventTableReplication tableReplication = mockTableReplicaiton("overrideBaseUrl");
EventTableReplication tableReplication = mockTableReplication("overrideBaseUrl");
runLifeCycleSuccess(tableReplication);
assertThat(transformation.getAvroSchemaDestinationFolder(), is("overrideBaseUrl"));
assertThat(transformation.getEventId(), is(EVENT_ID));
Expand All @@ -64,70 +64,70 @@ public void testOneReplicationsOverride() throws Exception {

@Test
public void testMultipleReplicationsOverride() throws Exception {
EventTableReplication tableReplication = mockTableReplicaiton("overrideBaseUrl");
EventTableReplication tableReplication = mockTableReplication("overrideBaseUrl");
runLifeCycleSuccess(tableReplication);
assertThat("overrideBaseUrl", is(transformation.getAvroSchemaDestinationFolder()));
assertThat(EVENT_ID, is(transformation.getEventId()));
assertThat("location", is(transformation.getTableLocation()));
EventTableReplication tableReplication2 = mockTableReplicaiton("overrideBaseUrl2");
assertThat(transformation.getAvroSchemaDestinationFolder(), is("overrideBaseUrl"));
assertThat(transformation.getEventId(), is(EVENT_ID));
assertThat(transformation.getTableLocation(), is("location"));
EventTableReplication tableReplication2 = mockTableReplication("overrideBaseUrl2");
runLifeCycleSuccess(tableReplication2);
assertThat(transformation.getAvroSchemaDestinationFolder(), is("overrideBaseUrl2"));
assertThat(transformation.getEventId(), is(EVENT_ID));
assertThat(transformation.getTableLocation(), is("location"));
}

@Test
public void testMultipleReplicationsOverrideToNull() throws Exception {
EventTableReplication tableReplication = mockTableReplicaiton("overrideBaseUrl");
public void testMultipleReplicationsSecondOverrideShouldUseDefault() throws Exception {
EventTableReplication tableReplication = mockTableReplication("overrideBaseUrl");
runLifeCycleSuccess(tableReplication);
assertThat("overrideBaseUrl", is(transformation.getAvroSchemaDestinationFolder()));
assertThat(EVENT_ID, is(transformation.getEventId()));
assertThat("location", is(transformation.getTableLocation()));
EventTableReplication tableReplication2 = mockTableReplicaiton(null);
assertThat(transformation.getAvroSchemaDestinationFolder(), is("overrideBaseUrl"));
assertThat(transformation.getEventId(), is(EVENT_ID));
assertThat(transformation.getTableLocation(), is("location"));
EventTableReplication tableReplication2 = mockTableReplication(null);
runLifeCycleSuccess(tableReplication2);
assertThat(transformation.getAvroSchemaDestinationFolder(), is("default"));
assertThat(transformation.getEventId(), is(EVENT_ID));
assertThat(transformation.getTableLocation(), is("location"));
}

@Test
public void testOneReplicationsOverrideFailure() throws Exception {
EventTableReplication tableReplication = mockTableReplicaiton("overrideBaseUrl");
public void testOneReplicationsOverrideFailureLifecycle() throws Exception {
EventTableReplication tableReplication = mockTableReplication("overrideBaseUrl");
runLifeCycleFailure(tableReplication);
assertThat(transformation.getAvroSchemaDestinationFolder(), is("overrideBaseUrl"));
assertThat(transformation.getEventId(), is(EVENT_ID));
assertThat(transformation.getTableLocation(), is("location"));
}

@Test
public void testMultipleReplicationsOverrideFailure() throws Exception {
EventTableReplication tableReplication = mockTableReplicaiton("overrideBaseUrl");
public void testMultipleReplicationsOverrideFailureLifecycle() throws Exception {
EventTableReplication tableReplication = mockTableReplication("overrideBaseUrl");
runLifeCycleSuccess(tableReplication);
assertThat("overrideBaseUrl", is(transformation.getAvroSchemaDestinationFolder()));
assertThat(EVENT_ID, is(transformation.getEventId()));
assertThat("location", is(transformation.getTableLocation()));
EventTableReplication tableReplication2 = mockTableReplicaiton("overrideBaseUrl2");
EventTableReplication tableReplication2 = mockTableReplication("overrideBaseUrl2");
runLifeCycleFailure(tableReplication2);
assertThat(transformation.getAvroSchemaDestinationFolder(), is("overrideBaseUrl2"));
assertThat(transformation.getEventId(), is(EVENT_ID));
assertThat(transformation.getTableLocation(), is("location"));
}

@Test
public void testMultipleReplicationsOverrideToNullFailure() throws Exception {
EventTableReplication tableReplication = mockTableReplicaiton("overrideBaseUrl");
public void testMultipleReplicationsSecondOverrideShouldUseDefaultFailureLifecycle() throws Exception {
EventTableReplication tableReplication = mockTableReplication("overrideBaseUrl");
runLifeCycleSuccess(tableReplication);
assertThat("overrideBaseUrl", is(transformation.getAvroSchemaDestinationFolder()));
assertThat(EVENT_ID, is(transformation.getEventId()));
assertThat("location", is(transformation.getTableLocation()));
EventTableReplication tableReplication2 = mockTableReplicaiton(null);
EventTableReplication tableReplication2 = mockTableReplication(null);
runLifeCycleFailure(tableReplication2);
assertThat(transformation.getAvroSchemaDestinationFolder(), is("default"));
assertThat(transformation.getEventId(), is(EVENT_ID));
assertThat(transformation.getTableLocation(), is("location"));
}

private EventTableReplication mockTableReplicaiton(String overrideBaseUrl) {
private EventTableReplication mockTableReplication(String overrideBaseUrl) {
EventTableReplication result = Mockito.mock(EventTableReplication.class);
Map<String, Object> transformOptions = new HashMap<>();
if (overrideBaseUrl != null) {
Expand Down

0 comments on commit a977f25

Please sign in to comment.