removed TODOs

ExpediaGroup · Feb 14, 2018 · d89dd91 · d89dd91
1 parent 38866f3
commit d89dd91
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/...us-train-s3-s3-copier/src/main/java/com/hotels/bdp/circustrain/s3s3copier/S3S3Copier.java b/...us-train-s3-s3-copier/src/main/java/com/hotels/bdp/circustrain/s3s3copier/S3S3Copier.java
@@ -158,10 +158,6 @@ private void submitCopyJobsFromListing(
       String sseAlgorithm = s3s3CopierOptions.getSSEAlgorithm();
       if (sseAlgorithm != null) {
         ObjectMetadata objectMetadata = new ObjectMetadata();
-        // TODO: should we only support AES256 (ObjectMetadata.AES_256_SERVER_SIDE_ENCRYPTION) or allow any string to be
-        // passed in?
-        // TODO: not sure if we can unit test the below, passing in valid and invalid values, probably not since s3proxy
-        // doesn't seem to support?
         objectMetadata.setSSEAlgorithm(sseAlgorithm);
         copyObjectRequest.setNewObjectMetadata(objectMetadata);
       }

diff --git a/...n-s3-s3-copier/src/main/java/com/hotels/bdp/circustrain/s3s3copier/S3S3CopierOptions.java b/...n-s3-s3-copier/src/main/java/com/hotels/bdp/circustrain/s3s3copier/S3S3CopierOptions.java
@@ -23,7 +23,6 @@
 
 import com.amazonaws.services.s3.transfer.TransferManagerConfiguration;
 
-//TODO: maybe I haven't looked in the right place but I can't seem to find where we document these
 public class S3S3CopierOptions {
 
   public static enum Keys {
@@ -42,7 +41,6 @@ public static enum Keys {
      * {@code S3_ENDPOINT_URI + "." + REGION} can be used as a copier option.
      */
     S3_ENDPOINT_URI("s3-endpoint-uri"),
-    // TODO: review naming of below and how this gets wired in and at what level we want this (s3 or s3s3) with DDC
     /**
      * Server-side encryption algorithm used when encrypting uploaded objects using AWS-managed keys.
      */