throwing the correct error #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnanaMJ
reviewed
Jan 10, 2019
| .warn("Unable to run compatibility for metastore client method {}. Will rethrow original exception: ", | ||
| method.getName(), compatibilityException); | ||
| } else { | ||
| // compatibily worked but threw non TApplicaitonException, rethrowing cause. |
There was a problem hiding this comment.
TApplicaitonException -> TApplicationException
abhimanyugupta07
approved these changes
Jan 10, 2019
massdosage
reviewed
Jan 10, 2019
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
| * Removed transitive (provided) dependency on `hbase-client`. | |||
| ### Fixed | |||
| * Removed 'isOpen()' method from CloseableMetaStoreClient. See [#11](https://github.com/HotelsDotCom/hcommon-hive-metastore/issues/11). | |||
| * Issue where the wrong exception was being propagated in the compatibility layer. | |||
There was a problem hiding this comment.
Could you create a quick GH issue with the relevant part of the stack trace and link it here? Just so in future we have a reference to this with some more detail.
massdosage
reviewed
Jan 10, 2019
| @Override | ||
| public Object answer(InvocationOnMock invocation) throws Throwable { | ||
| throw new RuntimeException(); |
There was a problem hiding this comment.
Shouldn't we still test what happens if something unexpected like a RuntimeException is thrown?
There was a problem hiding this comment.
Well no this test is fine,because any exception will be wrapped in a InvocationTargetException. So I changed this as it is more realistic.
massdosage
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16