Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shade Guava and hcommon-hive-metastore #26

Merged
merged 5 commits into from
Oct 4, 2018
Merged

Shade Guava and hcommon-hive-metastore #26

merged 5 commits into from
Oct 4, 2018

Conversation

AnanaMJ
Copy link
Contributor

@AnanaMJ AnanaMJ commented Oct 3, 2018 •
edited

Fixes #25

@AnanaMJ AnanaMJ requested a review from a team October 3, 2018 14:20
@coveralls
Copy link

coveralls commented Oct 3, 2018 •
edited

Coverage Status

Coverage remained the same at 54.2% when pulling a2b7c38 on issue-25 into bc6eb03 on master.

massdosage
massdosage suggested changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@massdosage massdosage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the minor version number for this as we've changed the packaging quite a bit...

pom.xml Show resolved Hide resolved
housekeeping-vacuum-tool/src/main/assembly/housekeeping-vacuum-tool-package.xml Show resolved Hide resolved
housekeeping-vacuum-tool/pom.xml Show resolved Hide resolved
@AnanaMJ
Copy link
Contributor Author

AnanaMJ commented Oct 3, 2018

@massdosage The SNAPSHOT version is 2.1.0 and it was updated because of the metastore tunnelling changes, which removed MetastoreTunnel. However, this was not released yet, so can I keep the version 2.1.0-SNAPSHOT?

@massdosage
Copy link
Contributor

Ah yes, so we've already incremented the minor version from that previous change, so yeah, keep it like it is.

massdosage
massdosage approved these changes Oct 3, 2018
View reviewed changes
Copy link
Contributor

@massdosage massdosage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's hold off on merging and doing a release until we get a confirmation back from the original users who reported this on whether it fixes the issue.

@AnanaMJ AnanaMJ merged commit b253087 into master Oct 4, 2018
@AnanaMJ AnanaMJ deleted the issue-25 branch October 4, 2018 09:45
@AnanaMJ AnanaMJ mentioned this pull request Oct 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@massdosage massdosage massdosage approved these changes

@abhimanyugupta07 abhimanyugupta07 abhimanyugupta07 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AnanaMJ @coveralls @massdosage @abhimanyugupta07