Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: part 2 #12

Merged
merged 16 commits into from Jul 21, 2022
Merged

Testing: part 2 #12

merged 16 commits into from Jul 21, 2022

Conversation

rex-9
Copy link
Owner

@rex-9 rex-9 commented Jul 13, 2022

Implementation

  • Used jest framework for testing.
  • Created a test file(s) ([..].test.js) for a file(s) containing the following functions:
    . a function for editing the task description.
    . a function for updating an item's 'completed' status.
    . the "Clear all completed" function.
  • Used the mock storage object you have created in Part 1 of this project to mock the localStorage updates.
  • Mocked the HTML elements to test DOM manipulation functions.
  • Made sure tests using the describe() method.

@rex-9 rex-9 changed the title Test2 Testing: part 2 Jul 13, 2022
Copy link

@FrederickMih FrederickMih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HtetNaing0814 ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

  • kindly update the Author section of the README file to contain all the members of this project. Let's also include LinkedIn, and Twitter links so that your information is open to recruiters.

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

src/test/crud.test.js Outdated Show resolved Hide resolved
@rex-9
Copy link
Owner Author

rex-9 commented Jul 14, 2022

Thank u so much for your review of the readme file.

Copy link

@roshan-bajgain roshan-bajgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @HtetNaing0814,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No linter errors. ✔️
  • GitHub flow is followed. ✔️
  • PR has a good title and summary. ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@rex-9 rex-9 merged commit 4cf8fcd into main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants