/
SingularityNewTaskChecker.java
329 lines (254 loc) · 11.9 KB
/
SingularityNewTaskChecker.java
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
package com.hubspot.singularity.scheduler;
import io.dropwizard.lifecycle.Managed;
import java.util.Collections;
import java.util.Map;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
import java.util.concurrent.ScheduledExecutorService;
import java.util.concurrent.ScheduledFuture;
import java.util.concurrent.TimeUnit;
import javax.inject.Singleton;
import org.apache.commons.lang3.time.DurationFormatUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import com.google.common.base.Optional;
import com.google.common.collect.Maps;
import com.google.common.util.concurrent.MoreExecutors;
import com.google.common.util.concurrent.ThreadFactoryBuilder;
import com.google.inject.Inject;
import com.hubspot.baragon.models.BaragonRequestState;
import com.hubspot.mesos.JavaUtils;
import com.hubspot.singularity.LoadBalancerRequestType;
import com.hubspot.singularity.LoadBalancerRequestType.LoadBalancerRequestId;
import com.hubspot.singularity.SingularityAbort;
import com.hubspot.singularity.SingularityAbort.AbortReason;
import com.hubspot.singularity.SingularityLoadBalancerUpdate;
import com.hubspot.singularity.SingularityLoadBalancerUpdate.LoadBalancerMethod;
import com.hubspot.singularity.SingularityTask;
import com.hubspot.singularity.SingularityTaskCleanup;
import com.hubspot.singularity.SingularityTaskCleanup.TaskCleanupType;
import com.hubspot.singularity.SingularityTaskHealthcheckResult;
import com.hubspot.singularity.SingularityTaskHistoryUpdate;
import com.hubspot.singularity.SingularityTaskHistoryUpdate.SimplifiedTaskState;
import com.hubspot.singularity.config.SingularityConfiguration;
import com.hubspot.singularity.data.TaskManager;
import com.hubspot.singularity.hooks.LoadBalancerClient;
import com.hubspot.singularity.sentry.SingularityExceptionNotifier;
/**
* Handles tasks we need to check for staleness | load balancer state, etc - tasks that are not part of a deploy. ie, new replacement tasks.
* Since we are making changes to these tasks, either killing them or blessing them, we don't have to do it actually as part of a lock.
* b/c we will use a queue to kill them.
*/
@Singleton
public class SingularityNewTaskChecker implements Managed {
private static final Logger LOG = LoggerFactory.getLogger(SingularityNewTaskChecker.class);
private final SingularityConfiguration configuration;
private final TaskManager taskManager;
private final LoadBalancerClient lbClient;
private final long killAfterUnhealthyMillis;
private final Map<String, Future<?>> taskIdToCheck;
private final ScheduledExecutorService executorService;
private final SingularityAbort abort;
private final SingularityExceptionNotifier exceptionNotifier;
@Inject
public SingularityNewTaskChecker(SingularityConfiguration configuration, LoadBalancerClient lbClient, TaskManager taskManager, SingularityExceptionNotifier exceptionNotifier, SingularityAbort abort) {
this.configuration = configuration;
this.taskManager = taskManager;
this.lbClient = lbClient;
this.abort = abort;
this.taskIdToCheck = Maps.newConcurrentMap();
this.killAfterUnhealthyMillis = TimeUnit.SECONDS.toMillis(configuration.getKillAfterTasksDoNotRunDefaultSeconds());
this.executorService = Executors.newScheduledThreadPool(configuration.getCheckNewTasksScheduledThreads(), new ThreadFactoryBuilder().setNameFormat("SingularityNewTaskChecker-%d").build());
this.exceptionNotifier = exceptionNotifier;
}
@Override
public void start() {
}
@Override
public void stop() {
MoreExecutors.shutdownAndAwaitTermination(executorService, 1, TimeUnit.SECONDS);
}
private boolean hasHealthcheck(SingularityTask task) {
return task.getTaskRequest().getDeploy().getHealthcheckUri().isPresent();
}
private int getDelaySeconds(SingularityTask task) {
int delaySeconds = configuration.getNewTaskCheckerBaseDelaySeconds();
if (hasHealthcheck(task)) {
delaySeconds += task.getTaskRequest().getDeploy().getHealthcheckIntervalSeconds().or(configuration.getHealthcheckIntervalSeconds());
} else if (task.getTaskRequest().getRequest().isLoadBalanced()) {
return delaySeconds;
}
delaySeconds += task.getTaskRequest().getDeploy().getDeployHealthTimeoutSeconds().or(configuration.getDeployHealthyBySeconds());
return delaySeconds;
}
// should only be called on tasks that are new and not part of a pending deploy.
public void enqueueNewTaskCheck(SingularityTask task) {
if (taskIdToCheck.containsKey(task.getTaskId().getId())) {
LOG.trace("Already had a newTaskCheck for task {}", task.getTaskId());
return;
}
int delaySeconds = getDelaySeconds(task);
enqueueCheckWithDelay(task, delaySeconds);
}
public void runNewTaskCheckImmediately(SingularityTask task) {
final String taskId = task.getTaskId().getId();
LOG.info("Requested immediate task check for {}", taskId);
CancelState cancelState = cancelNewTaskCheck(taskId);
if (cancelState == CancelState.NOT_CANCELED) {
LOG.debug("Task {} check was already done, not running again", taskId);
return;
} else if (cancelState == CancelState.NOT_PRESENT) {
LOG.trace("Task {} check was not present, not running immediately as it is assumed to be part of an active deploy", taskId);
return;
}
Future<?> future = executorService.submit(getTaskCheck(task));
taskIdToCheck.put(taskId, future);
}
public static enum CancelState {
NOT_PRESENT, CANCELED, NOT_CANCELED;
}
public CancelState cancelNewTaskCheck(String taskId) {
Future<?> future = taskIdToCheck.remove(taskId);
if (future == null) {
return CancelState.NOT_PRESENT;
}
boolean canceled = future.cancel(false);
LOG.trace("Canceling new task check ({}) for task {}", canceled, taskId);
if (canceled) {
return CancelState.CANCELED;
} else {
return CancelState.NOT_CANCELED;
}
}
private Runnable getTaskCheck(final SingularityTask task) {
return new Runnable() {
@Override
public void run() {
taskIdToCheck.remove(task.getTaskId().getId());
try {
checkTask(task);
} catch (Throwable t) {
LOG.error("Uncaught throwable in task check for task {}, re-enqueing", task, t);
exceptionNotifier.notify(t);
reEnqueueCheckOrAbort(task);
}
}
};
}
private void reEnqueueCheckOrAbort(SingularityTask task) {
try {
reEnqueueCheck(task);
} catch (Throwable t) {
LOG.error("Uncaught throwable re-enqueuing task check for task {}, aborting", task, t);
exceptionNotifier.notify(t);
abort.abort(AbortReason.UNRECOVERABLE_ERROR);
}
}
private void reEnqueueCheck(SingularityTask task) {
enqueueCheckWithDelay(task, configuration.getCheckNewTasksEverySeconds());
}
private void enqueueCheckWithDelay(final SingularityTask task, long delaySeconds) {
LOG.trace("Enqueuing a new task check for task {} with delay {}", task.getTaskId(), DurationFormatUtils.formatDurationHMS(TimeUnit.SECONDS.toMillis(delaySeconds)));
ScheduledFuture<?> future = executorService.schedule(getTaskCheck(task), delaySeconds, TimeUnit.SECONDS);
taskIdToCheck.put(task.getTaskId().getId(), future);
}
private enum CheckTaskState {
UNHEALTHY_KILL_TASK, OBSOLETE, CHECK_IF_OVERDUE, LB_IN_PROGRESS_CHECK_AGAIN, HEALTHY;
}
private void checkTask(SingularityTask task) {
final long start = System.currentTimeMillis();
final CheckTaskState state = getTaskState(task);
LOG.debug("Got task state {} for task {} in {}", state, task.getTaskId(), JavaUtils.duration(start));
switch (state) {
case CHECK_IF_OVERDUE:
if (isOverdue(task)) {
taskManager.createTaskCleanup(new SingularityTaskCleanup(Optional.<String> absent(), TaskCleanupType.OVERDUE_NEW_TASK, System.currentTimeMillis(), task.getTaskId(),
Optional.of(String.format("Task did not become healthy after %s", JavaUtils.durationFromMillis(killAfterUnhealthyMillis)))));
} else {
reEnqueueCheck(task);
}
break;
case LB_IN_PROGRESS_CHECK_AGAIN:
reEnqueueCheck(task);
break;
case UNHEALTHY_KILL_TASK:
taskManager.createTaskCleanup(new SingularityTaskCleanup(Optional.<String> absent(), TaskCleanupType.UNHEALTHY_NEW_TASK, System.currentTimeMillis(), task.getTaskId(),
Optional.of("Task is not healthy")));
break;
case HEALTHY:
case OBSOLETE:
break;
}
}
private CheckTaskState getTaskState(SingularityTask task) {
if (!taskManager.isActiveTask(task.getTaskId().getId())) {
return CheckTaskState.OBSOLETE;
}
SimplifiedTaskState taskState = SingularityTaskHistoryUpdate.getCurrentState(taskManager.getTaskHistoryUpdates(task.getTaskId()));
switch (taskState) {
case DONE:
return CheckTaskState.OBSOLETE;
case WAITING:
case UNKNOWN:
return CheckTaskState.CHECK_IF_OVERDUE;
case RUNNING:
break;
}
if (hasHealthcheck(task)) {
Optional<SingularityTaskHealthcheckResult> healthCheck = taskManager.getLastHealthcheck(task.getTaskId());
if (!healthCheck.isPresent()) {
return CheckTaskState.CHECK_IF_OVERDUE;
}
if (healthCheck.get().isFailed()) {
return CheckTaskState.UNHEALTHY_KILL_TASK;
}
}
// task is running + has succeeded healthcheck if available.
if (!task.getTaskRequest().getRequest().isLoadBalanced()) {
return CheckTaskState.HEALTHY;
}
Optional<SingularityLoadBalancerUpdate> lbUpdate = taskManager.getLoadBalancerState(task.getTaskId(), LoadBalancerRequestType.ADD);
SingularityLoadBalancerUpdate newLbUpdate = null;
final LoadBalancerRequestId loadBalancerRequestId = new LoadBalancerRequestId(task.getTaskId().getId(), LoadBalancerRequestType.ADD, Optional.<Integer> absent());
if (!lbUpdate.isPresent() || lbUpdate.get().getLoadBalancerState() == BaragonRequestState.UNKNOWN) {
taskManager.saveLoadBalancerState(task.getTaskId(), LoadBalancerRequestType.ADD,
new SingularityLoadBalancerUpdate(BaragonRequestState.UNKNOWN, loadBalancerRequestId, Optional.<String> absent(), System.currentTimeMillis(), LoadBalancerMethod.PRE_ENQUEUE, Optional.<String> absent()));
newLbUpdate = lbClient.enqueue(loadBalancerRequestId, task.getTaskRequest().getRequest(), task.getTaskRequest().getDeploy(), Collections.singletonList(task), Collections.<SingularityTask> emptyList());
} else {
Optional<CheckTaskState> maybeCheckTaskState = checkLbState(lbUpdate.get().getLoadBalancerState());
if (maybeCheckTaskState.isPresent()) {
return maybeCheckTaskState.get();
}
newLbUpdate = lbClient.getState(loadBalancerRequestId);
}
taskManager.saveLoadBalancerState(task.getTaskId(), LoadBalancerRequestType.ADD, newLbUpdate);
Optional<CheckTaskState> maybeCheckTaskState = checkLbState(newLbUpdate.getLoadBalancerState());
if (maybeCheckTaskState.isPresent()) {
return maybeCheckTaskState.get();
}
return CheckTaskState.LB_IN_PROGRESS_CHECK_AGAIN;
}
private Optional<CheckTaskState> checkLbState(BaragonRequestState lbState) {
switch (lbState) {
case SUCCESS:
case INVALID_REQUEST_NOOP:
return Optional.of(CheckTaskState.HEALTHY);
case CANCELED:
case FAILED:
return Optional.of(CheckTaskState.UNHEALTHY_KILL_TASK);
case CANCELING:
case UNKNOWN:
case WAITING:
break;
}
return Optional.absent();
}
private boolean isOverdue(SingularityTask task) {
final long taskDuration = System.currentTimeMillis() - task.getTaskId().getStartedAt();
final boolean isOverdue = taskDuration > killAfterUnhealthyMillis;
if (isOverdue) {
LOG.debug("Task {} is overdue (duration: {}), allowed limit {}", task.getTaskId(), JavaUtils.durationFromMillis(taskDuration), JavaUtils.durationFromMillis(killAfterUnhealthyMillis));
}
return isOverdue;
}
}