refactor method param

HubSpot · May 10, 2017 · a3ebc45 · a3ebc45
1 parent 59047bc
commit a3ebc45
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...tyService/src/main/java/com/hubspot/singularity/mesos/SingularityMesosOfferScheduler.java b/...tyService/src/main/java/com/hubspot/singularity/mesos/SingularityMesosOfferScheduler.java
@@ -269,7 +269,7 @@ private double score(SingularityOfferHolder offerHolder, SingularitySchedulerSta
     final SlaveMatchState slaveMatchState = slaveAndRackManager.doesOfferMatch(offerHolder, taskRequest, stateCache);
 
     if (matchesResources && slaveMatchState.isMatchAllowed()) {
-      return score(offer, taskRequest, maybeSlaveUsage);
+      return score(offer.getHostname(), taskRequest, maybeSlaveUsage);
     } else {
       offerHolder.addRejectedTask(pendingTaskId);
 
@@ -283,9 +283,9 @@ private double score(SingularityOfferHolder offerHolder, SingularitySchedulerSta
   }
 
   @VisibleForTesting
-  double score(Offer offer, SingularityTaskRequest taskRequest, Optional<SingularitySlaveUsageWithId> maybeSlaveUsage) {
+  double score(String hostname, SingularityTaskRequest taskRequest, Optional<SingularitySlaveUsageWithId> maybeSlaveUsage) {
     if (isMissingUsageData(maybeSlaveUsage)) {
-      LOG.info("Slave {} has missing usage data ({}). Will default to {}", offer.getSlaveId().getValue(), maybeSlaveUsage, configuration.getDefaultOfferScoreForMissingUsage());
+      LOG.info("Slave {} has missing usage data ({}). Will default to {}", hostname, maybeSlaveUsage, configuration.getDefaultOfferScoreForMissingUsage());
       return configuration.getDefaultOfferScoreForMissingUsage();
     }