Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please tell me why is this Guicier than Guicie? #8

Closed
darrenhaken opened this issue Jul 8, 2016 · 6 comments
Closed

Please tell me why is this Guicier than Guicie? #8

darrenhaken opened this issue Jul 8, 2016 · 6 comments

Comments

@darrenhaken
Copy link

Never thought I'd ask that on Github...

@jhaber
Copy link
Member

jhaber commented Jul 8, 2016

Hey @darrenhaken thanks for the question! This package was initially extracted from https://github.com/HubSpot/Singularity where it was added by @hgschmie in this PR. The design is a large departure from its predecessor, https://github.com/HubSpot/dropwizard-guice, which is why it's a separate project and wasn't integrated into dropwizard-guice.

The most notable change is that the injector is created during the run phase rather than the initialize phase. This makes it much easier to run Guice in Stage.PRODUCTION with eager bindings. Additionally, it does away with the concept of auto-discovered HealthCheck, Managed, Task, etc. It does, however, take any of these classes bound in Guice and register them with dropwizard.

In general, this repo favors eagerness and explicitness, whereas dropwizard-guice encouraged implicit magic and laziness.

@jhaber jhaber closed this as completed Jul 8, 2016
@darrenhaken
Copy link
Author

Are you planning on support Guicier in the future?

I'm working on a greenfield Dropwizard project right now and looking to integrate DI into it.

@jhaber
Copy link
Member

jhaber commented Jul 10, 2016

Yup, we'll be keeping it up to date with dropwizard releases

@darrenhaken
Copy link
Author

That's great! I ran into some issues using the library, if I post a Gist and open an issue will you be able to help?

@jhaber
Copy link
Member

jhaber commented Jul 10, 2016

For sure!

@darrenhaken
Copy link
Author

Brilliant I'll post it in the next couple of days. Thanks for the speedy reply 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants