Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELFunctionDefinition do not work because of Guava #654

Open
ylacaute opened this issue Apr 28, 2021 · 1 comment
Open

ELFunctionDefinition do not work because of Guava #654

ylacaute opened this issue Apr 28, 2021 · 1 comment

Comments

@ylacaute
Copy link
Contributor

ylacaute commented Apr 28, 2021

Jinjava : 2.5.7
Java : 8

There are 2 problems to use ELFunctionDefinition.

1) Guava
The Guava lib coming from Jinjava 2.5.7 is 19, but it generates a Guava class exception. Adding Guava 21 solve the problem.

2) Namespace not supported
Namespaces are still not supported, the example in the README is wrong. A workaround is just to set an empty String for the namespace.

@ylacaute ylacaute changed the title ELFunctionDefinition do not work with argument ELFunctionDefinition do not work because of Guava Apr 28, 2021
@chrisirhc
Copy link
Contributor

Looks like there's a usage of toImmutableMap which requires guava 21.

ImmutableMap.toImmutableMap(Map.Entry::getKey, e -> e.getValue().defaultValue())

Perhaps the pom.xml should be updated to enforce this requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants