Fixes for bower.json #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix jquery dependency - Include all production files in `main` - Ignore everything else
|
Works for me, thanks @pdf. |
|
We will have to conduct an inventory of exactly which versions of jQuery are supported. I added an issue to fix whatever causes problems on 2.0.0. |
|
Is it possible to retag or bump the version? It's sadly required until the bower rewrite introduces git ref support. |
|
I just pushed v 1.3.1, let me know if that is not what you need. |
|
The 1.3.1 tag somehow seems to have picked up the old https://github.com/HubSpot/messenger/blob/3c392d37e12ec113dcf7c25b1886fea95f0a7d4d/bower.json |
|
Ah, yea. Would a 1.3.1a release help? |
|
Sadly, that's not semver, so I think bower will barf :-( |
|
Ah yea, and 1.3.1-a would compare lower than 1.3.1. I'll try and get 1.3.2 out in the next day or so. |
|
No worries, thanks Zack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainRefs #39
I'm pretty new to all this JS packaging stuff, but it seems like currently people tend to maintain two repositories for dealing with bower, with a bower-specific repository that contains only the built version and a
bower.json. That seems like a whole lot of wasted effort, so I don't know if you want to go that far, hopefully that gets resolved after the bower rewrite is finished. For now I've just fixed made the above changes so that it works - though files are still deployed to messenger/build/(js|css) - and doesn't ship all the extra stuff like libs and source. All in all, bower still seems a little confused about whatmainis actually meant to be currently, so, I've just made sure it references everything required.I don't know if this is expected to work with JQuery 2.0.0, but if not, it might also be worth adding a dependency restriction to
~1.9.1