Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefixes to CSS classes #5

Closed
wants to merge 5 commits into from
Closed

Conversation

mrchess
Copy link

@mrchess mrchess commented Feb 22, 2013

Added $prefix in the CSS, and a baseCSSPrefix class in the JS.

Also added a global in the JS where you can specify theme, and a simple test file.

This commit fixes issue #4.

Cheers.

@mrchess
Copy link
Author

mrchess commented Feb 22, 2013

I ended up prefixing everything in the SASS instead of replacing "messenger" so that it could be completely scoped. There was also a small classname dependency on bootstrap for the "block" theme that I didn't scope, but I made a comment in the coffee file.

@zackbloom
Copy link
Contributor

Thanks for writing it up. I would merge if messenger- was the prefix, meaning you could change it. That would help people potentially using bootstrap themes that prefix alerts. I don't like the inclusion of the 'hubspot-' default in a public repo, and also don't think its necessary for everything to be double-namespaced.

@mrchess
Copy link
Author

mrchess commented Feb 27, 2013

I think I removed all the things you were concerned about with this commit. Got rid of double namespacing, and now everything is just "messenger". Basically the CSS is like how it was originally, except now you can specify a prefix if you want.

You can test w/ different themes in the test.html file (gotta rebuild tho when you change theme in the coffee).

@zackbloom zackbloom closed this May 13, 2013
@zackbloom
Copy link
Contributor

I'm closing this because I haven't seen enough support from the community that it's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants