New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add funtion support for confirmCancel #2168
Conversation
Can anyone help to see if there is really a problem with this pr? It doesn't seem to pass the 'cognitive complexity' test, but I don't really know how to reduce it any more. (In fact, I only added one judgement). |
Co-authored-by: Robert Wagner <rwwagner90@gmail.com>
Hi, is there anything else I need to do? I see that this PR has not been merged, I just don't know if there is anything else that needs to be done. |
Hello, thank you for this feature. @RobbieTheWagner, when do you plan to release a new version in npm with this update? Thank you |
A new version has been released |
demo
Promise function:
https://github.com/shipshapecode/shepherd/blob/1076b0c37465cb48968b5f7159e08033cceaab20/test/unit/tour.spec.js#L295-L335
Unit tests have been passed.