Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serve responses with 404 (instead of 500) error code for invalid URL routes #35

Closed
cvan opened this issue May 16, 2018 · 1 comment
Closed

serve responses with 404 (instead of 500) error code for invalid URL routes #35

cvan opened this issue May 16, 2018 · 1 comment
Labels
bug

Comments

@cvan
Copy link
Contributor

cvan commented May 16, 2018

  1. load an invalid route, such as https://hubs.mozilla.com/404 or https://hubs.mozilla.com/google4afac22ec4cd831b.html (from Google's robots.txt tester)
  2. notice a 500 Internal Server Error response is seen (not a 404 Not Found)

Screenshot of 500 curl call in the terminal
Screenshot of 500 page in Firefox
@cvan cvan added the bug label May 16, 2018
@cvan cvan mentioned this issue May 18, 2018
Closed
@brianpeiris
Copy link
Contributor

This must have been fixed at some point. We return 404s as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianpeiris @cvan