Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action cannot build on Windows with OpenSSL #113

Open
Hugal31 opened this issue Apr 6, 2023 · 2 comments
Open

Github action cannot build on Windows with OpenSSL #113

Hugal31 opened this issue Apr 6, 2023 · 2 comments

Comments

@Hugal31
Copy link
Owner

Hugal31 commented Apr 6, 2023

We get this error : D:\a\yara-rust\yara-rust\target\debug\build\yara-sys-a7d675839598f617\out\yara\libyara\crypto.h(38): fatal error C1083: Cannot open include file: 'openssl/crypto.h': No such file or directory

Both on https://github.com/Hugal31/yara-rust/actions/runs/4627586826/jobs/8185675294?pr=108 and https://github.com/Hugal31/yara-rust/actions/runs/4627507725/jobs/8185510282.
But it worked fine on Yara 4.3.0 PR, and nothing relevant changed since.

@Hugal31
Copy link
Owner Author

Hugal31 commented Apr 7, 2023

OpenSSL disabled on Windows for now in #108.

@vthib
Copy link
Contributor

vthib commented Apr 7, 2023

Not sure why it worked before and suddently didn't work, but I think adding YARA_OPENSSL_DIR instead of OPENSSL_DIR should solve the issue. I had the same issue on updating to yara-rust 0.19 and adding YARA_OPENSSL_DIR fixed it: https://github.com/vthib/boreal/pull/31/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants