Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure with latest Hunspell #12

Closed
jeroen opened this issue Nov 3, 2017 · 8 comments
Closed

Failure with latest Hunspell #12

jeroen opened this issue Nov 3, 2017 · 8 comments
Assignees

Comments

@jeroen
Copy link

jeroen commented Nov 3, 2017

I have updated the bundled dictionaries in the hunspell package but now TeXCheckR fails it's checks. Could you help me debug what the issue is here?

devtools::install_github("ropensci/hunspell")
@HughParsonage HughParsonage self-assigned this Nov 3, 2017
@HughParsonage
Copy link
Owner

TeXCheckR used XX as a placeholder for an error in a particular unit test:

See https://travis-ci.org/HughParsonage/TeXCheckR/jobs/296321822 at line 2488.

Spellcheck failed: 'XX'
✖ 2: Box XX\@.
          ^^

whereas following the package update the spell check does not fail.

@jeroen
Copy link
Author

jeroen commented Nov 3, 2017

Hmz so the word XX was added to the dictionary? Or is there something else going on?

@HughParsonage
Copy link
Owner

HughParsonage commented Nov 3, 2017

Yes, added to the dictionary; nothing else going on.

As you might have seen, that build was only 20 hours ago, and it determined XX was a spelling error according to hunspell.

Frankly, my test requiring an error when XX is seen is not a very good test since it's a valid roman numeral. I just included it because it did reliably fail. If hunspell's dictionary is updated at the cost of this test, so be it. I would just change the test.

@jeroen
Copy link
Author

jeroen commented Nov 3, 2017

OK is there any chance you can update that test to some word that will more reliably fail and submit to CRAN? I can't submit the hunspell update until this problem is resolved :(

@HughParsonage
Copy link
Owner

Yes, of course: sorry for delaying the release. I only recently updated TeXCheckR, however. CRAN might reject my package on the grounds of too frequent updates, but I'll try to explain the situation in my submission.

Do you anticipate any further updates before you lodge with CRAN?

@jeroen
Copy link
Author

jeroen commented Nov 3, 2017

Ah well if they make a fuz I can temporary remove the word xx from the dictionary. Such a silly blocker. Don't expect further upgrades; I had already submitted but they rejected because it broke TeXCheckR.

@jeroen
Copy link
Author

jeroen commented Nov 3, 2017

The new version of hunspell is on CRAN now. Your package will start failing soon :) So just submit a new version of TeXCheckR to CRAN and add a comment in the submission that this fixes a problem with the new hunspell pkg.

@HughParsonage
Copy link
Owner

On CRAN now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants